Closed Bug 785622 Opened 8 years ago Closed 8 years ago

Some files are always rebuilt during incremental builds because of dangling .pp files

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Since bug 766975 landed, people have had dangling .pp files in the .deps directories in the objdir, and as a result, their incremental build have been rebuilding some files even when rebuilding them was not required. This results in extra time waiting for builds.
The cl.py changes are due to the fact that we were actually not storing the .pp file in the right directory when the object file name contains a path (such as when building libjpeg). This makes the behaviour match that of unix builds.

I checked that all the .pp files we generate during a clobber build are included this way, and media/libvpx and js/xpconnect/src are the only places where we have custom-generated files that generate .pp files that aren't included in the variables I added, so they are now in an extra variable.
Attachment #655331 - Flags: review?(khuey)
Blocks: 462463
Duplicate of this bug: 779268
Assignee: nobody → mh+mozilla
https://hg.mozilla.org/mozilla-central/rev/c2e464e9524b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.