767207 - [Fx14] Only fire what's new pages in certain locales

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Laura Forrest]

With the launch of Fx14 we'd like to only show the what's new page to certain locales, not all, since Firefox for Android will not be available to all locales. 

So - I'm wondering if we can set it to only display to:

-English (en)
-French (fr)
-Italian (it)
-German (de)
-Spain (es)
-Japanese (ja)
-Korean (ko)

The What's New page would not display in all other locales. 

Is this possible? Let's gauge the cost/benefit here. As we may want to do this in the future outside of Fx14 it's partially a RelEng capability that will be good for Engagement to understand better.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

This is pretty do-able. 

For just a few locales like that we'd generate the snippets with 'actions   silent' in the patcher config then do something like this (untested!):
 cd /opt/aus2/snippets/staging
 rsync -a Firefox-14.0.1-build1{,-withWN}/
 for f in "Firefox-14.0.1-build1-withWN/*/*/*/$l -type f"; do
   sed -i -e 's/^actions.*$//' $f
 done
and repeat for test snippets. I've morphed en -> en-US, es -> es-ES, ja -> ja-JP & ja-JP-mac, and assumed you want to target all version (10.0+) and platforms.

If we go ahead with this please set it as a blocker on bug 758795.

Comment 2

[Laura Forrest]

Thanks Nick!

One change to comment 0 - we'd like to add the Russian locale, Russian (ru) and all spanish and english speaking locales, making the final list:

-English speaking, all: (en-US)(en-GB)
-French (fr)
-Italian (it)
-German (de)
-Spanish speaking, all: (es-ES)(es-AR)(es-CL)(es-MX)
-Japanese (ja-JP ja-JP-mac)
-Korean (ko)
- Russian (ru)

Yes, all versions and platforms. 

Setting as a blocker. Thanks!

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [cvs] globally disable WN pages

This would land about the time we build 14.0.whatever-we're-up-to for real.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Tested code snippet with updated locale list, assuming we're doing 14.0.1 (ie no extra mobile releases):

 locales="en-US en-GB fr it de es-ES es-AR es-CL es-MX ja ja-JP-mac ko ru"

 # backup auto-generated snippets
 cd /opt/aus2/snippets/staging
 rsync -a Firefox-14.0.1-build1{,-withoutWN}/
 rsync -a Firefox-14.0.1-build1-test{,-withoutWN}/

 for l in $locales; do
   for f in `find Firefox-14.0.1-build1{,-test}/*/*/*/*/$l -type f`; do
     sed -i '/^actions.*$/d' $f
   done
 done

 # repush test snippets
 pushsnip Firefox-14.0.1-build1-test

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 636539 [details] [diff] [review]
[cvs] globally disable WN pages

Checking in mozRelease-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/mozRelease-branch-patcher2.cfg,v  <--  mozRelease-branch-patcher2.cfg
new revision: 1.36; previous revision: 1.35
done

We should run the shell script in comment #4 after the updates builder runs. We'll also have extra partials to generate, but I'm pretty sure AUS only reads the action out of the complete snippet so we just make sure that we don't upload complete snippets then.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Should this bug be marked RESO-FIXED based on comment #5?

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

The actual work was documented at 
 https://wiki.mozilla.org/Releases/Firefox_14.0.1/BuildNotes-Updates#Adjust_What.27s_New_in_snippets
All done.