Closed Bug 767384 Opened 11 years ago Closed 11 years ago

The script from the dropdown is kept when loading a page with no scripts after loading one with scripts and opening the Debugger

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Version:
15 Branch
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 16

People

(Reporter: ioana_damy, Assigned: vporof)

References

Details

(Whiteboard: [testday-20120706])

Attachments

(1 file, 2 obsolete files)

v2
4.92 KB, patch
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120621 Firefox/15.0a2 (20120621042006)

STR:
1. Load http://htmlpad.org/debugger/ in the browser.
2. Open the Debugger (Tools->Web developer->Debugger, or press Ctrl+Shift+S).
3. Load in the same tab a page with no JSs:
e.g.:
<!DOCTYPE html> 
<html>
  <head></head>
  <body>asasdfasd</body>
</html>

The script that was selected in the dropdown before step 3 stays loaded for the page without any scripts too.
Yup, I can reproduce this. Shouldn't happen. Taking.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch v1 (obsolete) — — Splinter Review 

        Attachment #638677 -
        Flags: review?(past)

    
    

    
  
Comment on attachment 638677 [details] [diff] [review]
v1

Review of attachment 638677 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a test that makes sure we won't regress this.

        Attachment #638677 -
        Flags: review?(past) → review+

    
    

    
  
Just to add that If the no-script html page is loaded by hitting the back or the forward button then the bug shows up.
Whiteboard: [testday-20120706]
Whiteboard: [testday-20120706] → [testday-20120706][waiting-for-test][reviewed]

    
    

    
  
still not resolved please see the screenshot attached

browserversion : Aurora 15.0a2 (2012-07-12)
OS : Windows 7 32-bit

    
    

    
  

      
      
      
      

        Attached image
          
        screenshot (obsolete)
        — 
      

    


  

    
    

    
  
(In reply to Diwakar Sharma from comment #7)
> still not resolved please see the screenshot attached

Well, the patch hasn't landed yet, we're waiting for a test.

    
    

    
  
Getting back to this right now.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v2
        — 
          — Splinter Review
      

    


  
Added test.

        Attachment #641799 -
        Attachment is obsolete: true

        Attachment #638677 -
        Attachment is obsolete: true
Whiteboard: [testday-20120706][waiting-for-test][reviewed] → [testday-20120706][land-in-fx-team]

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/21d5e58533e0
Whiteboard: [testday-20120706][land-in-fx-team] → [testday-20120706][fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/21d5e58533e0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [testday-20120706][fixed-in-fx-team] → [testday-20120706]
Target Milestone: --- → Firefox 16

    
    

    
  
I checked at latest Aurora (Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/16.0 Firefox/16.0) and Nightly and the bug is resolved.

However there is a difference between Aurora and Nightly. At Nightly when the no-script page is loaded then the dropdown menu has the tag "No scripts". At Aurora the dropdown menu hasn't any tag, it is just blank.

Can somebody confirm this behavior at Aurora? Is this behavior intended?

    
    

    
  
(In reply to Alfredos-Panagiotis Damkalis from comment #14)
> I checked at latest Aurora (Mozilla/5.0 (X11; Linux x86_64; rv:16.0)
> Gecko/16.0 Firefox/16.0) and Nightly and the bug is resolved.
> 
> However there is a difference between Aurora and Nightly. At Nightly when
> the no-script page is loaded then the dropdown menu has the tag "No
> scripts". At Aurora the dropdown menu hasn't any tag, it is just blank.
> 
> Can somebody confirm this behavior at Aurora? Is this behavior intended?

I think this is the fix from bug 771481 that isn't in Aurora.

    
    

    
  
You are right, so I change this one to verified. Thanks for the fix :)
Status: RESOLVED → VERIFIED

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.