Last Comment Bug 767488 - Cache windows handle used for stackwalking
: Cache windows handle used for stackwalking
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: :Ehsan Akhgari (busy, don't ask for review please)
:
Mentors:
: 763723 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-22 11:31 PDT by Benoit Girard (:BenWa)
Modified: 2012-12-14 14:05 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part 1: Cache the current process handle after reading it for the first time during stack walking (2.55 KB, patch)
2012-06-22 14:55 PDT, :Ehsan Akhgari (busy, don't ask for review please)
dbaron: review+
Details | Diff | Review

Description Benoit Girard (:BenWa) 2012-06-22 11:31:03 PDT
Currently we duplicate the handles every time we walk the stack:
http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsStackWalk.cpp#459

We should cache these when start the profiler instead of duplicating them each time.
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2012-06-22 14:55:18 PDT
Created attachment 635929 [details] [diff] [review]
Part 1: Cache the current process handle after reading it for the first time during stack walking
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-07-09 14:51:12 PDT
Comment on attachment 635929 [details] [diff] [review]
Part 1: Cache the current process handle after reading it for the first time during stack walking

r=dbaron
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2012-07-09 15:13:21 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cbf12886c89
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-10 15:49:16 PDT
https://hg.mozilla.org/mozilla-central/rev/2cbf12886c89
Comment 5 Vladan Djeric (:vladan) 2012-12-14 14:05:41 PST
*** Bug 763723 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.