Closed Bug 767488 Opened 11 years ago Closed 11 years ago

Cache windows handle used for stackwalking

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: BenWa, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Part 1: Cache the current process handle after reading it for the first time during stack walking
2.55 KB, patch
dbaron
: review+
Details | Diff | Splinter Review 
Currently we duplicate the handles every time we walk the stack:
http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsStackWalk.cpp#459

We should cache these when start the profiler instead of duplicating them each time.
Comment on attachment 635929 [details] [diff] [review]
Part 1: Cache the current process handle after reading it for the first time during stack walking

r=dbaron
Attachment #635929 - Flags: review?(dbaron) → review+
Blocks: 713278
No longer blocks: 713278
https://hg.mozilla.org/mozilla-central/rev/2cbf12886c89
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.