Closed
Bug 767488
Opened 10 years ago
Closed 10 years ago
Cache windows handle used for stackwalking
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: BenWa, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
Currently we duplicate the handles every time we walk the stack: http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsStackWalk.cpp#459 We should cache these when start the profiler instead of duplicating them each time.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #635929 -
Flags: review?(dbaron)
Comment 2•10 years ago
|
||
Comment on attachment 635929 [details] [diff] [review] Part 1: Cache the current process handle after reading it for the first time during stack walking r=dbaron
Attachment #635929 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cbf12886c89
Target Milestone: --- → mozilla16
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2cbf12886c89
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•