Closed Bug 767512 Opened 8 years ago Closed 8 years ago

Fix connection pressure for non-SSL CONNECT

Categories

(Core :: Networking: HTTP, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jduell.mcbugs, Unassigned)

References

Details

Attachments

(1 file)

Patrick: let me know if you think this merits beta/aurora. W/o this patch CONNECT connections will count as regular ones, so regular cxns will report "underpressure" more than they should.  Seems like a perf hit but not full stoppage of connectivity. (We already fixed things so non-SSL CONNECTS don't count toward the per-proxy connection limit:  we just didn't fix it for IsUnderPressure() yet).
Attachment #635851 - Flags: review?(mcmanus)
Blocks: 767516
Since this depends on bug 713026 and that isn't making it to aurora/beta, it's moot to consider backporting this as well.
Depends on: 713026
Comment on attachment 635851 [details] [diff] [review]
v1: fix IsUnderPressure for non-SSL CONNECT

Review of attachment 635851 [details] [diff] [review]:
-----------------------------------------------------------------

this won't have any meaningful impact as "under pressure" only applies to pipelining, and websockets connections don't pipeline (and they are quickly upgraded out of the connection count completely). But its right nonetheless :)
Attachment #635851 - Flags: review?(mcmanus) → review+
Push backed out for M5 orange:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=d45ca69b67a3

Couldn't see you on #developers or see any try run URLs listed in-bug in the four bugs in the push, or I would have tried to find out if just part of it could have been backed out.

https://hg.mozilla.org/integration/mozilla-inbound/rev/51cff2123f45
https://hg.mozilla.org/mozilla-central/rev/90b265723879
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.