The default bug view has changed. See this FAQ.

Change access key of joinChatMenuItem

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: nONoNonO, Assigned: aceman)

Tracking

({polish, ux-consistency, ux-error-prevention})

14 Branch
Thunderbird 19.0
x86
Windows 7
polish, ux-consistency, ux-error-prevention
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird-esr1718+ fixed)

Details

(Whiteboard: [ux-papercut])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
At the moment the new "Join Chat" menu option under Tools uses the letter "O" as its access key. The letter "O" was always used for Options. Instead of using Alt-T+O to go to options, I now how to type Alt-T+O+O+Enter.

Please change the access key of Join Chat to something else, like J, which isn't used in the standard Tools menu...

comm-central/mail/locales/en-US/chrome/messenger/messenger.dtd:
--- <!ENTITY joinChatCmd.accesskey "o">
+++ <!ENTITY joinChatCmd.accesskey "J">
Status: UNCONFIRMED → NEW
Component: Mail Window Front End → Instant Messaging
Ever confirmed: true
Keywords: polish, ux-consistency, ux-error-prevention
QA Contact: front-end → instant-messaging
Whiteboard: [ux-papercut]
I was just about to file this bug.  It's even more onerous, given that I don't use chat and the menu system insists on honoring access keys for even menuitems that are inactive.
Whiteboard: [ux-papercut] → [ux-papercut][good first bug]
(Assignee)

Comment 2

5 years ago
Created attachment 673973 [details] [diff] [review]
patch

Who wanted to mark a ux-papercut bug as GFB to let it rot till eternity? :)

'J' does not seem to be a good key to underline as the underline vanishes in the sub-baseline part of 'J'. I'll try 't'.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #673973 - Flags: ui-review?(bwinton)
Attachment #673973 - Flags: review?(florian)
(Reporter)

Comment 3

5 years ago
Hmz, there goes my good first bug :~(
The underline doesn't vanish from the J in my Windows 7. Look for instance at View -> Sort by -> _J_unk Status...
(Assignee)

Comment 4

5 years ago
It does not completely vanish, it is just not well visible as the J crosses through it.

Sorry for taking your GFB bug, but you were silent for 4 months:)
You can still take it and finish it.
Comment on attachment 673973 [details] [diff] [review]
patch

Yeah, I could buy "t".

ui-r=me.
Attachment #673973 - Flags: ui-review?(bwinton) → ui-review+
Attachment #673973 - Flags: review?(florian) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: [ux-papercut][good first bug] → [ux-papercut]
https://hg.mozilla.org/comm-central/rev/31e1452b669b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
(Assignee)

Comment 7

4 years ago
Comment on attachment 673973 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): IM landing
User impact if declined: user visible conflict in accesskeys
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): none, does not even affect localizations.
Attachment #673973 - Flags: approval-comm-esr17?
Attachment #673973 - Flags: approval-comm-esr17? → approval-comm-esr17+
https://hg.mozilla.org/releases/comm-esr17/rev/590426b2cae8
status-thunderbird-esr17: --- → fixed
tracking-thunderbird-esr17: --- → 18+
You need to log in before you can comment on or make changes to this bug.