Closed Bug 767897 Opened 12 years ago Closed 12 years ago

Change access key of joinChatMenuItem

Categories

(Thunderbird :: Instant Messaging, defect)

Product:
Thunderbird
Component:
Instant Messaging
Version:
14 Branch
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird-esr1718+ fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 19.0
Tracking Flags:
Tracking Status
thunderbird-esr17 18+ fixed

People

(Reporter: nONoNonO, Assigned: aceman)

Details

(Keywords: polish, ux-consistency, ux-error-prevention, Whiteboard: [ux-papercut])

Attachments

(1 file)

patch
1.23 KB, patch
florian
: review+
bwinton
: ui-review+
standard8
: approval-comm-esr17+
Details | Diff | Splinter Review 
At the moment the new "Join Chat" menu option under Tools uses the letter "O" as its access key. The letter "O" was always used for Options. Instead of using Alt-T+O to go to options, I now how to type Alt-T+O+O+Enter.

Please change the access key of Join Chat to something else, like J, which isn't used in the standard Tools menu...

comm-central/mail/locales/en-US/chrome/messenger/messenger.dtd:
--- <!ENTITY joinChatCmd.accesskey "o">
+++ <!ENTITY joinChatCmd.accesskey "J">
Status: UNCONFIRMED → NEW
Component: Mail Window Front End → Instant Messaging
Ever confirmed: true
Keywords: polish, ux-consistency, ux-error-prevention
QA Contact: front-end → instant-messaging
Whiteboard: [ux-papercut]
I was just about to file this bug.  It's even more onerous, given that I don't use chat and the menu system insists on honoring access keys for even menuitems that are inactive.
Whiteboard: [ux-papercut] → [ux-papercut][good first bug]
Attached patch patch — — Splinter Review 
Who wanted to mark a ux-papercut bug as GFB to let it rot till eternity? :)

'J' does not seem to be a good key to underline as the underline vanishes in the sub-baseline part of 'J'. I'll try 't'.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #673973 - Flags: ui-review?(bwinton)
Attachment #673973 - Flags: review?(florian)
Hmz, there goes my good first bug :~(
The underline doesn't vanish from the J in my Windows 7. Look for instance at View -> Sort by -> _J_unk Status...
It does not completely vanish, it is just not well visible as the J crosses through it.

Sorry for taking your GFB bug, but you were silent for 4 months:)
You can still take it and finish it.
Comment on attachment 673973 [details] [diff] [review]
patch

Yeah, I could buy "t".

ui-r=me.
Attachment #673973 - Flags: ui-review?(bwinton) → ui-review+
Attachment #673973 - Flags: review?(florian) → review+
Keywords: checkin-needed
Whiteboard: [ux-papercut][good first bug] → [ux-papercut]
https://hg.mozilla.org/comm-central/rev/31e1452b669b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
Comment on attachment 673973 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): IM landing
User impact if declined: user visible conflict in accesskeys
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky): none, does not even affect localizations.
Attachment #673973 - Flags: approval-comm-esr17?
Attachment #673973 - Flags: approval-comm-esr17? → approval-comm-esr17+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: