767911 - Missing no restart attribute on Location Bar Enhancer's AMO homepage

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Girish Sharma [:Optimizer]]

The No Restart Tag on Location Bar Enhancer is not present anymore, while the addon is restartless.
IIRC, it was present a few days ago.
See the url

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/blob/master/apps/files/utils.py#L79

mysql> select * from files where version_id=1345559 \G
*************************** 1. row ***************************
                  id: 156225
          version_id: 1345559
         platform_id: 1
            filename: location_bar_enhancer-4.9-fx.xpi
...
          no_restart: 0

The install.rdf in http://releases.mozilla.org/pub/mozilla.org/addons/333011/location_bar_enhancer-4.9-fx.xpi has <bootstrap>true</bootstrap> so I'm not sure what's up.

Comment 2

[Matt Basta [:basta]]

The install.rdf for this add-on is completely invalid. Element names in standard install.rdf files are namespaced with <em:...>. The one bundled with the add-on, however, defines the namespace as <r:...> and applies it to the <RDF> and <Description> tags (which should NOT be namespaced).

Please see https://developer.mozilla.org/en/Install_Manifests for an example of a properly constructed install.rdf file.

Comment 3

[Girish Sharma [:Optimizer]]

(In reply to Matt Basta from comment #2)
> The install.rdf for this add-on is completely invalid. Element names in
> standard install.rdf files are namespaced with <em:...>. The one bundled
> with the add-on, however, defines the namespace as <r:...> and applies it to
> the <RDF> and <Description> tags (which should NOT be namespaced).
> 
> Please see https://developer.mozilla.org/en/Install_Manifests for an example
> of a properly constructed install.rdf file.

So was the site buggy prior to this version ? As I have always been able to see the no restart tag on the amo site home page of this addon (the url provided). Also, all my other addons are using the similar rdf format, so I think the problem that you mentioned is not causing this bug.

Comment 4

[Kris Maglione [:kmag]]

Matt: That install.rdf is perfectly invalid. All that should matter is that the element has the correct namespace. It shouldn't matter what the namespace prefix is or whether even it has one. The default namespace for the document is the extension manager namespace (which is not uncommon in install manifests), and the validator doesn't seem to have a problem with it (nor would I expect it to, from what I know about its install.rdf parsing code).

Comment 5

[Girish Sharma [:Optimizer]]

(In reply to Kris Maglione [:kmag] from comment #4)
> Matt: That install.rdf is perfectly invalid. All that should matter is that
> the element has the correct namespace. It shouldn't matter what the
> namespace prefix is or whether even it has one. The default namespace for
> the document is the extension manager namespace (which is not uncommon in
> install manifests), and the validator doesn't seem to have a problem with it
> (nor would I expect it to, from what I know about its install.rdf parsing
> code).

I think you mean perfectly valid..

Comment 6

[Kris Maglione [:kmag]]

Rather, is perfectly *valid*...

Comment 8

[Matt Basta [:basta]]

Does anyone know which version of rdflib is running on prod?

Comment 9

[Girish Sharma [:Optimizer]]

As a matter of fact, similar to bug 768088, I too have the restartless tag amongst th etag list, but no "No Restart" tag besides the addon name. The only difference is that I don't have any beta channel.

Comment 10

[Matt Basta [:basta]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> https://github.com/mozilla/zamboni/blob/master/apps/files/utils.py#L79

I can confirm that Extractor is working properly using a fresh install of Zamboni using rdflib v3.0.0.

Comment 11

[Girish Sharma [:Optimizer]]

If something has to be done on my side to fix this issue, please can someone tell it ?

Comment 12

[Wil Clouser [:clouserw]]

add-on is marked restartless now