768296 - Ignore role="presentation" when global ARIA attributes are present or referred by ARIA relationship

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

For any element with an explicit or inherited role of presentation, user
agents MUST ignore any non-global, role-specific WAI-ARIA states and
properties. However, the user agent MUST always expose global WAI-ARIA
states and properties to accessibility APIs, even if an element has an
explicit or inherited role of presentation.

Comment 1

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #0)
> However, the user agent MUST always expose global WAI-ARIA
> states and properties to accessibility APIs, even if an element has an
> explicit or inherited role of presentation.

it contradicts to ARIA impl guide (http://www.w3.org/WAI/PF/aria-implementation/#exclude_elements2):

"The following elements are not exposed via the accessibility API and user agents MUST NOT include them in the accessibility tree:

    Elements with presentation as the first mappable role in the role attribute string, according to the rules for presentation role defined in Accessible Rich Internet Applications (WAI-ARIA) 1.0 [ARIA]. "

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Yep - one of them has to change. Note I'm reporting these as bugs as soon as I receive them (via email).

Comment 3

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #2)
> Yep - one of them has to change. Note I'm reporting these as bugs as soon as
> I receive them (via email).

Personally I report only bugs when I receive reports via emails. Since these bugs is filed by you and you are trustee person then these "bugs" are confusing.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Sigh. Unfortunately this is a CR/508 requirement.

So generally we're being asked to ignore role="presentation" in more cases; even though it is really an author error. (See http://www.w3.org/WAI/PF/aria/states_and_properties#global_states)

Let's fold related bug 768299 into this one.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

(This bug currently feels wrong to me)

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Text I received:

   When you have a global aria attribute applied to an element with
   role="presentation" treat it as if role="presentation" is not there.
   When you have an element with role="presentation" that is referenced by
   an ARIA relationship from another element treat it as if the
   role="presentation" is not there.

Comment 8

[Rich Schwerdtfeger]

I will add that element that inherit presentational roles like a td from a presentational table also fail when global aria attributes are applied. I just discovered this in the test cases I have created.

Comment 9

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #7)
> Text I received:
> 
>    When you have a global aria attribute applied to an element with
>    role="presentation" treat it as if role="presentation" is not there.
>    When you have an element with role="presentation" that is referenced by
>    an ARIA relationship from another element treat it as if the
>    role="presentation" is not there.

Ah, this is different from original bug summary and makes sense to me.

Comment 10

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #9)
> (In reply to David Bolter [:davidb] from comment #7)
> > Text I received:
> > 
> >    When you have a global aria attribute applied to an element with
> >    role="presentation" treat it as if role="presentation" is not there.
> >    When you have an element with role="presentation" that is referenced by
> >    an ARIA relationship from another element treat it as if the
> >    role="presentation" is not there.
> 
> Ah, this is different from original bug summary and makes sense to me.

I'd say it makes about as much sense as "please clean up my mess, and oh by the way please make sure its really fast", but if the spec requires it / existing web stuff depends on it I guess we have to deal :/

Comment 11

[alexander :surkov (:asurkov)]

Rich, David, should the bug be fixed before the ARIA impl guide is updated?

Comment 12

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #10)

> I'd say it makes about as much sense as "please clean up my mess, and oh by
> the way please make sure its really fast", but if the spec requires it /
> existing web stuff depends on it I guess we have to deal :/

true, web is always a mess

Comment 13

[alexander :surkov (:asurkov)]

1) add HasUniversalAriaProperty(content) || HasRelatedContent(content) to IsFocusable() check on role="presentation" (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessibilityService.cpp#1003)
2) add tests to tree/test_aria_presentation.html, for example, for

<div id="airaglobalprop_cnt">
  <div role="presentation" aria-owns="ariaowned">has aria-owns</div>
  <div role="presentation" id="ariaowned>referred by aria-owns</div>
</div>

Comment 14

[alexander :surkov (:asurkov)]

Attachment: patch

taking it since it's wanted for ARIA testsuite.

Comment 15

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 661111 [details] [diff] [review]
patch

Review of attachment 661111 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsAccessibilityService.cpp
@@ +999,5 @@
>    nsRoleMapEntry* roleMapEntry = aria::GetRoleMap(aNode);
> +
> +  // If the element is focusable or global ARIA attribute is applied to it or
> +  // it is referenced by ARIA relationship then treat role="presentation" on
> +  // the element as the role is not there.

nit: I would change this all to something like
// Ignore presentation role in some cases.

Comment 17

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #15)

> > +  // If the element is focusable or global ARIA attribute is applied to it or
> > +  // it is referenced by ARIA relationship then treat role="presentation" on
> > +  // the element as the role is not there.
> 
> nit: I would change this all to something like
> // Ignore presentation role in some cases.

Ignore seems to be more ambiguous that "is not there". If I'd use ignore then I say ignore completely probably. And I'd prefer to list all cases since methods names aren't all very descriptive for this case.

Comment 18

[alexander :surkov (:asurkov)]

Comment on attachment 661111 [details] [diff] [review]
patch

David if you steal review then please cancel the existing one.

Comment 19

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to alexander :surkov from comment #17)
> (In reply to David Bolter [:davidb] from comment #15)
> 
> > > +  // If the element is focusable or global ARIA attribute is applied to it or
> > > +  // it is referenced by ARIA relationship then treat role="presentation" on
> > > +  // the element as the role is not there.
> > 
> > nit: I would change this all to something like
> > // Ignore presentation role in some cases.
> 
> Ignore seems to be more ambiguous that "is not there". If I'd use ignore
> then I say ignore completely probably. And I'd prefer to list all cases
> since methods names aren't all very descriptive for this case.

Treat the nit as optional :)

(In reply to alexander :surkov from comment #18)
> Comment on attachment 661111 [details] [diff] [review]
> patch
> 
> David if you steal review then please cancel the existing one.

Sounds good.

Comment 20

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb646fdccce

Comment 21

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/2cb646fdccce