768343 - <dfn> elements not being migrated properly

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Jean-Yves Perrier [:teoli]]

<dfn> is often used and is safe. It should be whitelisted.

Numerous pages use it (all CSS references are broken because of this)

Comment 1

[Luke Crouch [:groovecoder]]

Same deal here: can fork & edit https://github.com/mozilla/kuma/blob/master/apps/wiki/models.py#L38 and send a PR to add more tags.

Comment 2

[Jean-Yves Perrier [:teoli]]

Unfortunately the models.py#L38 already have the <dfn> (and <sub>, <sup>, <caption>) element but the problem is still there.

Comment 3

[Jean-Yves Perrier [:teoli]]

Oh I have understood!

The tags on the pages has been converted to <dfn> and we have to manually edit the pages that have them!

Is there a way to automate that (>100 pages!)

Comment 4

[Jean-Yves Perrier [:teoli]]

It may be that import script from DekiWiki is doing this. Old revisions are ok (<dfn> imported correctly), but recent revisions are not.

See https://developer-new.mozilla.org/en-US/docs/CSS/transition-duration$history
the May 7th revision has been imported correctly. But June 1st not. So the more editions happen on the DekiWiki site, the more such problems are imported into the Kuma site.

Comment 5

[Les Orchard [:lorchard]]

Here's what I think the problem is: When a document is saved on Kuma (or when it's initially migrated), a copy of the content is run through the Bleach sanitizer and saved in the DB. That copy is what gets served up when you view the page.

If the Bleach whitelist is changed, there's no mechanism to re-save any documents with tags that were previously disallowed by Bleach. So, try editing and saving the affected documents and see if that fixes things.

If that fixes things, maybe we can look at adding a tool to re-save documents after changes in the whitelist. Pending that, just edit & resave documents with tags that have been newly added to the whitelists.

Comment 6

[Les Orchard [:lorchard]]

...and having said the above, re-saving doesn't seem to fix it, despite <dfn> being in the white list. Still looking at things.

Comment 7

[Les Orchard [:lorchard]]

Oh, wait, no I think it did work:
https://developer-new.mozilla.org/en-US/docs/CSS/transition-duration

I might have just run afoul of bug 765649 and needed to hit refresh. Let me see if I can repeat on CSS/animation

Comment 8

[Les Orchard [:lorchard]]

I think this one is actually fixed

Comment 9

[jakub.g]

FWIW, I still see a lot of <dfn> on the page here:

https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/getOwnPropertyDescriptor

Comment 10

[Jean-Yves Perrier [:teoli]]

Are you sure? I don't see any...

Comment 11

[jakub.g]

Ha, don't see them any more. Either someone ad-hoc fixed it, flushed it etc. or some other issue happened (web cache somewhere? not the browser cache issue on my side for sure). I should post a screenshot the next time to be more credible :)

Comment 12

[Jean-Yves Perrier [:teoli]]

:-) Don't worry. On this one I believe it may have been cache issue. I still get a few of them once in a while and usually an edit followed by a save fix them.

Don't bother about the screenshot, just report the future links :-)