768367 - B2G RIL: send/received SMS failed on Otoro

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

E/GeckoConsole( 115): [JavaScript Error: "this.mRIL.rilContext.icc is
null" {file:"jar:file:///system/b2g/omni.ja!/components/SmsDatabaseService.js" line:
361}]

The problem should be related to Bug 766862,
but we should make the code more defensively to prevent Sms failed due to SIM problem

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch to check if rilContext.icc is defined

This patch is from vivien in https://bugzilla.mozilla.org/attachment.cgi?id=636062&action=edit

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Also verified in Makuro.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Sorry, it's a Akami.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Akami also has this problem because of Bug 768428
so we also need this patch on akami

Comment 5

[Philipp von Weitershausen [:philikon]]

Comment on attachment 636631 [details] [diff] [review]
Patch to check if rilContext.icc is defined

Looks ok to me. Let's see if we can fix bug 766862 somehow.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try server:
https://tbpl.mozilla.org/?tree=Try&rev=609ec6fcafff

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f6a23947fc33

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f6a23947fc33