768463 - Ensure that all links that intend to take you outside of the marketplace app into the browser are using target=blank

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Jason Smith [:jsmith]]

For the marketplace to act as a proper open web app, we will need to make that any links to intend to go out of the app into the browser are using target=blank. All other links that do not use target=blank will open in-app. This bug is a tracking bug for any changes that need to happen on the marketplace side to make this happen.

For reference, the platform bugs this are as follows:

* Desktop - bug 752666
* Android - bug 766802
* B2G - bug 764707

Comment 1

[Andy McKay]

All external apps should be using outgoing anyway. Should just be a matter of adding it to that. The trickier part will be checking that we are "in-app" so that we don't do this for all desktop users.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Andy McKay [:andym] from comment #1)
> All external apps should be using outgoing anyway. Should just be a matter
> of adding it to that. The trickier part will be checking that we are
> "in-app" so that we don't do this for all desktop users.

Thanks to bug 762195, we can target in-app by checking window.locationbar.visible == true.

Comment 3

[Potch [:potch]]

https://github.com/mozilla/zamboni/commit/29755f8 should do the trick. checking it out on an otoro shortly.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Potch [:potch] from comment #3)
> https://github.com/mozilla/zamboni/commit/29755f8 should do the trick.
> checking it out on an otoro shortly.

B2G hasn't supported this feature yet. Only desktop has this implemented right now.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #4)
> (In reply to Potch [:potch] from comment #3)
> > https://github.com/mozilla/zamboni/commit/29755f8 should do the trick.
> > checking it out on an otoro shortly.
> 
> B2G hasn't supported this feature yet. Only desktop has this implemented
> right now.

Or it's not implemented on B2G yet is what I mean. Only implemented on desktop. But it plans to be implemented on B2G for basecamp.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Is this a QA or dev bug? Can we get a list of pages that don't have target="_blank" that need to?

Comment 7

[Jason Smith [:jsmith]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #6)
> Is this a QA or dev bug? Can we get a list of pages that don't have
> target="_blank" that need to?

Originally marked qawanted, but actually I don't think this is QA level - this should be a productwanted bug, as we need to determine what belongs in-app for marketplace vs. in the browser.

Fligtar - What parts of marketplace should be operated in-app? Which parts should be operated within a browser? We are trying to determine what belongs in the marketplace app vs. belonging in the browser.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

(In reply to Jason Smith [:jsmith] from comment #7)
> Fligtar - What parts of marketplace should be operated in-app? Which parts
> should be operated within a browser? We are trying to determine what belongs
> in the marketplace app vs. belonging in the browser.

/developers/*
/admin/*
*/statistics/*

But I'm not Fligtar.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Is there work to be done here?

Comment 10

[Jason Smith [:jsmith]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #9)
> Is there work to be done here?

Probably. We need to define what that is and test it. Hmm...I know one issue is:

- Go to https://marketplace.mozilla.org/en-US/developers/ and select "reference"

That should take you to the browser, but instead, you remain in the app.

We could take a qa testing approach if we wish. Krupa - What do you think?

Comment 11

[Andreas Gal :gal]

How are we doing here?

Comment 12

[Wil Clouser [:clouserw]]

With the new designs and their minimal links I think the answer is that only links to an external domain (header stuff, potentially, and the app's homepage) should open in a browser.  I'm removing the productwanted request.

Comment 13

[krupa raj[:krupa]]

This includes- 

* App Privacy Policy
* Support Site
* Homepage

Comment 14

[Potch [:potch]]

https://github.com/mozilla/zamboni/commit/232355d

Comment 15

[Christopher Van Wiemeersch [:cvan]]

User-profile links are still being loaded within the app:
https://marketplace-dev.allizom.org/users/route66

Statistics:
https://marketplace-dev.allizom.org/app/hypno/

Policies link on Report Abuse:
https://marketplace-dev.allizom.org/app/hypno/abuse

Comment 16

[Potch [:potch]]

Not sure what you mean about the user profile links- I'm not going to assume they exist outside the app part of the marketplace

Comment 17

[Christopher Van Wiemeersch [:cvan]]

(In reply to Potch [:potch] from comment #16)
> Not sure what you mean about the user profile links- I'm not going to assume
> they exist outside the app part of the marketplace

Yeah I think we can disable them for this round of mobile-only design. But we should fo sho at least ...

1) disable user profile links
2) have stats links on detail pages be target="_blank"
3) have links in privacy policies be target="_blank"

Comment 18

[Potch [:potch]]

https://github.com/mozilla/zamboni/commit/42203a5

Comment 19

[Jason Smith [:jsmith]]

Not on-device - removing nom.