Closed Bug 768463 Opened 10 years ago Closed 10 years ago

Ensure that all links that intend to take you outside of the marketplace app into the browser are using target=blank

Categories

(Marketplace Graveyard :: General, defect, P1)

defect

Tracking

(blocking-kilimanjaro:+)

RESOLVED FIXED
2012-08-16
blocking-kilimanjaro +

People

(Reporter: jsmith, Assigned: potch)

References

Details

For the marketplace to act as a proper open web app, we will need to make that any links to intend to go out of the app into the browser are using target=blank. All other links that do not use target=blank will open in-app. This bug is a tracking bug for any changes that need to happen on the marketplace side to make this happen.

For reference, the platform bugs this are as follows:

* Desktop - bug 752666
* Android - bug 766802
* B2G - bug 764707
blocking-basecamp: --- → ?
blocking-kilimanjaro: --- → ?
All external apps should be using outgoing anyway. Should just be a matter of adding it to that. The trickier part will be checking that we are "in-app" so that we don't do this for all desktop users.
(In reply to Andy McKay [:andym] from comment #1)
> All external apps should be using outgoing anyway. Should just be a matter
> of adding it to that. The trickier part will be checking that we are
> "in-app" so that we don't do this for all desktop users.

Thanks to bug 762195, we can target in-app by checking window.locationbar.visible == true.
Assignee: nobody → thepotch
https://github.com/mozilla/zamboni/commit/29755f8 should do the trick. checking it out on an otoro shortly.
(In reply to Potch [:potch] from comment #3)
> https://github.com/mozilla/zamboni/commit/29755f8 should do the trick.
> checking it out on an otoro shortly.

B2G hasn't supported this feature yet. Only desktop has this implemented right now.
(In reply to Jason Smith [:jsmith] from comment #4)
> (In reply to Potch [:potch] from comment #3)
> > https://github.com/mozilla/zamboni/commit/29755f8 should do the trick.
> > checking it out on an otoro shortly.
> 
> B2G hasn't supported this feature yet. Only desktop has this implemented
> right now.

Or it's not implemented on B2G yet is what I mean. Only implemented on desktop. But it plans to be implemented on B2G for basecamp.
Blocks: 766201
No longer blocks: 752013
No longer blocks: Blocking-FFA-WebRT1+
blocking-basecamp: ? → +
blocking-kilimanjaro: ? → +
Priority: -- → P1
Target Milestone: --- → 2012-07-12
Is this a QA or dev bug? Can we get a list of pages that don't have target="_blank" that need to?
Keywords: qawanted
Keywords: qawanted
(In reply to Chris Van Wiemeersch [:cvan] from comment #6)
> Is this a QA or dev bug? Can we get a list of pages that don't have
> target="_blank" that need to?

Originally marked qawanted, but actually I don't think this is QA level - this should be a productwanted bug, as we need to determine what belongs in-app for marketplace vs. in the browser.

Fligtar - What parts of marketplace should be operated in-app? Which parts should be operated within a browser? We are trying to determine what belongs in the marketplace app vs. belonging in the browser.
Keywords: productwanted
(In reply to Jason Smith [:jsmith] from comment #7)
> Fligtar - What parts of marketplace should be operated in-app? Which parts
> should be operated within a browser? We are trying to determine what belongs
> in the marketplace app vs. belonging in the browser.

/developers/*
/admin/*
*/statistics/*

But I'm not Fligtar.
Is there work to be done here?
(In reply to Chris Van Wiemeersch [:cvan] from comment #9)
> Is there work to be done here?

Probably. We need to define what that is and test it. Hmm...I know one issue is:

- Go to https://marketplace.mozilla.org/en-US/developers/ and select "reference"

That should take you to the browser, but instead, you remain in the app.

We could take a qa testing approach if we wish. Krupa - What do you think?
Blocks: 766199
How are we doing here?
Priority: P1 → P2
With the new designs and their minimal links I think the answer is that only links to an external domain (header stuff, potentially, and the app's homepage) should open in a browser.  I'm removing the productwanted request.
Keywords: productwanted
Priority: P2 → P1
Target Milestone: 2012-07-12 → 2012-08-16
This includes- 

* App Privacy Policy
* Support Site
* Homepage
https://github.com/mozilla/zamboni/commit/232355d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
User-profile links are still being loaded within the app:
https://marketplace-dev.allizom.org/users/route66

Statistics:
https://marketplace-dev.allizom.org/app/hypno/

Policies link on Report Abuse:
https://marketplace-dev.allizom.org/app/hypno/abuse
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Not sure what you mean about the user profile links- I'm not going to assume they exist outside the app part of the marketplace
(In reply to Potch [:potch] from comment #16)
> Not sure what you mean about the user profile links- I'm not going to assume
> they exist outside the app part of the marketplace

Yeah I think we can disable them for this round of mobile-only design. But we should fo sho at least ...

1) disable user profile links
2) have stats links on detail pages be target="_blank"
3) have links in privacy policies be target="_blank"
https://github.com/mozilla/zamboni/commit/42203a5
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Not on-device - removing nom.
blocking-basecamp: + → ---
You need to log in before you can comment on or make changes to this bug.