768666 - Adjust the size of text selection handles as you zoom in/out

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[:Margaret Leibovic]

Ideally we'd want the handles to have a constant size, independent of zoom, but an improvement would be to just avoid them ever being super tiny or super huge.

Comment 2

[:Margaret Leibovic]

Attachment: patch

Simply scaling the handles with CSS works surprisingly well. I had to get rid of the vertical offset and add a horizontal offset in positionHandles, which feels sketchy, but I wasn't able to figure out why exactly the positions were slightly off.

Tested on a Nexus S running 2.3.6.

Comment 3

[:Margaret Leibovic]

A build, if anyone wants to try: https://dl.dropbox.com/u/3358452/text-selection-zoom.apk

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/924b157541bc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/924b157541bc

Comment 6

[:Margaret Leibovic]

Comment on attachment 637969 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this should be part of the text selection mass uplift (bug 695173), but was fixed after the roll-up patch in that bug was created
User impact if declined: handles zoom as the page zooms
Testing completed (on m-c, etc.): landed on m-c 6/30
Risk to taking this patch (and alternatives if risky): low risk 
String or UUID changes made by this patch: n/a

Comment 7

[:Margaret Leibovic]

Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6