The default bug view has changed. See this FAQ.

Remote debugger asks for host:port, displays http://host:port/ as default value

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Developer Tools: Debugger
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philikon, Assigned: vporof)

Tracking

unspecified
Firefox 16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

http://cdn.memegenerator.net/instances/400x/22557117.jpg
(Assignee)

Comment 1

5 years ago
Wow... how did we not notice this until now?!
Assignee: nobody → vporof
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
LOL
Priority: P1 → --
Priority: -- → P1
(Assignee)

Comment 3

5 years ago
Created attachment 638668 [details] [diff] [review]
v1
Attachment #638668 - Flags: review?(past)
Comment on attachment 638668 [details] [diff] [review]
v1

Review of attachment 638668 [details] [diff] [review]:
-----------------------------------------------------------------

Although I agree with the spirit of these changes, overall this patch is a regression, since the prompt cannot be dismissed now by clicking on Cancel.
Attachment #638668 - Flags: review?(past) → review-
would like to get this before the merge on monday.
(Assignee)

Comment 6

5 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> would like to get this before the merge on monday.

Shall happen.
(Assignee)

Comment 7

5 years ago
Created attachment 642340 [details] [diff] [review]
v1

There.
Attachment #638668 - Attachment is obsolete: true
Attachment #642340 - Flags: review?(past)
Comment on attachment 642340 [details] [diff] [review]
v1

Review of attachment 642340 [details] [diff] [review]:
-----------------------------------------------------------------

Cancel now works, but there is still a brief flashing of the debugger window. Can't we get rid of that, too?

::: browser/devtools/debugger/debugger-view.js
@@ +120,5 @@
>  
> +      if (!result) {
> +        return false;
> +      }
> +      if ((parts = input.value.split(":")).length === 2) {

This is unnecessarily complicated, since you don't avoid the extra line of the |parts| declaration above :-)
Attachment #642340 - Flags: review?(past) → review+
(Assignee)

Comment 9

5 years ago
(In reply to Panos Astithas [:past] from comment #8)
> Comment on attachment 642340 [details] [diff] [review]
> v1
> 
> Review of attachment 642340 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Cancel now works, but there is still a brief flashing of the debugger
> window. Can't we get rid of that, too?
> 
> ::: browser/devtools/debugger/debugger-view.js
> @@ +120,5 @@
> >  
> > +      if (!result) {
> > +        return false;
> > +      }
> > +      if ((parts = input.value.split(":")).length === 2) {
> 
> This is unnecessarily complicated, since you don't avoid the extra line of
> the |parts| declaration above :-)

The flashing was there before.
With the current implementation, it cannot be removed, since the prompt is blocking and debugger content window is not shown yet. Bug 751677 will take care of this.
(In reply to Victor Porof from comment #9)
> With the current implementation, it cannot be removed, since the prompt is
> blocking and debugger content window is not shown yet. Bug 751677 will take
> care of this.

OK then.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/842865c36ff1
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/842865c36ff1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.