Closed Bug 768677 Opened 11 years ago Closed 11 years ago

Remote debugger asks for host:port, displays http://host:port/ as default value

Categories

(DevTools :: Debugger, defect, P1)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 16

People

(Reporter: philikon, Assigned: vporof)

Details

Attachments

(1 file, 1 obsolete file)

v1
2.34 KB, patch
past
: review+
Details | Diff | Splinter Review 
Wow... how did we not notice this until now?!
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P1
LOL
Priority: P1 → --
Priority: -- → P1
Attached patch v1 (obsolete) — — Splinter Review 

        Attachment #638668 -
        Flags: review?(past)

    
    

    
  
Comment on attachment 638668 [details] [diff] [review]
v1

Review of attachment 638668 [details] [diff] [review]:
-----------------------------------------------------------------

Although I agree with the spirit of these changes, overall this patch is a regression, since the prompt cannot be dismissed now by clicking on Cancel.

        Attachment #638668 -
        Flags: review?(past) → review-

    
    

    
  
would like to get this before the merge on monday.

    
    

    
  
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> would like to get this before the merge on monday.

Shall happen.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1
        — 
          — Splinter Review
      

    


  
There.

        Attachment #638668 -
        Attachment is obsolete: true

        Attachment #642340 -
        Flags: review?(past)

    
    

    
  
Comment on attachment 642340 [details] [diff] [review]
v1

Review of attachment 642340 [details] [diff] [review]:
-----------------------------------------------------------------

Cancel now works, but there is still a brief flashing of the debugger window. Can't we get rid of that, too?

::: browser/devtools/debugger/debugger-view.js
@@ +120,5 @@
>  
> +      if (!result) {
> +        return false;
> +      }
> +      if ((parts = input.value.split(":")).length === 2) {

This is unnecessarily complicated, since you don't avoid the extra line of the |parts| declaration above :-)

        Attachment #642340 -
        Flags: review?(past) → review+

    
    

    
  
(In reply to Panos Astithas [:past] from comment #8)
> Comment on attachment 642340 [details] [diff] [review]
> v1
> 
> Review of attachment 642340 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Cancel now works, but there is still a brief flashing of the debugger
> window. Can't we get rid of that, too?
> 
> ::: browser/devtools/debugger/debugger-view.js
> @@ +120,5 @@
> >  
> > +      if (!result) {
> > +        return false;
> > +      }
> > +      if ((parts = input.value.split(":")).length === 2) {
> 
> This is unnecessarily complicated, since you don't avoid the extra line of
> the |parts| declaration above :-)

The flashing was there before.
With the current implementation, it cannot be removed, since the prompt is blocking and debugger content window is not shown yet. Bug 751677 will take care of this.

    
    

    
  
(In reply to Victor Porof from comment #9)
> With the current implementation, it cannot be removed, since the prompt is
> blocking and debugger content window is not shown yet. Bug 751677 will take
> care of this.

OK then.
Whiteboard: [land-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/842865c36ff1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.