768703 - Use 32x32 favicons in location bar results

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect)

Description

[Andrew Hurle [:ahurle]]

Once support for 32x32 favicons is added (bug 751712) and the first stage of the location bar theme overhaul is done (bug 587909), we should display the 32x32 favicons in the location bar results.  We will likely need to change the alignment of other parts of the results.  Also consider how smaller favicons will look - if we're going to display the representative color behind them, we'll need a way to find that (bug 634139).

Comment 1

[Andrew Hurle [:ahurle]]

See new mockups on project page that show how to handle smaller favicons:
https://wiki.mozilla.org/images/d/d9/AwesomeBarResults-16x16-Colored-Border.png
https://wiki.mozilla.org/images/b/b4/AwesomeBarResults-16x16-Gray-Border.png

There is a possibility of not having a color to show in the results, like under the failure conditions in findRepresentativeColor (bug 634139), or seeing a result before image processing has finished, so we will have to fall back to something else in that case.  The effect shown in the gray border screenshot should work (though the background gradient may look out of place next to the colored ones that lack it).

Comment 2

[Caspy7]

(In reply to Andrew Hurle [:ahurle] from comment #1)
> The effect shown in the gray
> border screenshot should work (though the background gradient may look out
> of place next to the colored ones that lack it).

Perhaps mockups which mix the two would help to visualize it?

Comment 3

[u428464]

It would be visually nice to have such big icons, but I think it will cause troubles when the search bar is merged with the location bar. How will the search suggestion look ? The location bar will have to show more results and 32x32 icons will take a lot of space.

Comment 4

[Alex Shilov]

I think the big icons looks cool, even on no high-dpi desktop. So, how is this bug doing? It is almost a year since this bug and many related and blocking bugs was opened. And none of them are fixed (see dependency tree). I don't really know why don't just use gray border until bug "cache representative color" is fixed? Or dont use border at all.
For testing it can be turned as option via about:config. 
As far as i know - mobile version of firefox use 32x32 icon and cache them. Firefox on Hidpi screen also use hidpi version of icons, see bug 702538, bug 828508, bug 795495.
I already tried 
  .ac-site-icon {
    min-height: 32px!important;
    min-width: 32px!important;
    image-rendering: -moz-crisp-edges;
  }
This looks good, but not as good as with hi-res icons support. And this hack don't load 32x32 favicons, even if they are exist. 

So I definitely want this feature as soon as possible. Thanks.

Comment 5

[Alex Shilov]

I'm sorry to bother you, but there is another half year passed. So i just want to know, when this feature will be landed?

Comment 6

[Dão Gottwald [:dao]]

Closing as per bug 1034542 comment 3.

Comment 7

[Florian Bender]

(In reply to Dão Gottwald [:dao] from comment #6)
> Closing as per bug 1034542 comment 3.

Isn't this bug still needed for higher-res icons on HDPI screens?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Florian Bender from comment #7)
> (In reply to Dão Gottwald [:dao] from comment #6)
> > Closing as per bug 1034542 comment 3.
> 
> Isn't this bug still needed for higher-res icons on HDPI screens?

No, that's a separate concern.

Comment 9

[Karl Tomlinson (:karlt)]

I think bug 854956 tracks support for high dpi displays.