768727 - Droid Bionic interprets SHIFT+7 as number '7', not ampersand '&'

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Chris Peterson [:cpeterson]]

gatordan reported this problem at https://news.ycombinator.com/item?id=4162812

> in every website I visit when I type an & symbol into an input element it is 
> replaced with a 7 (e.g. I type "password&" the input shows "password7"). It's 
> happening across all sites for both text and more importantly password inputs so 
> I can't login to many of sites I regularly visit and really try the app.
> 
> I'm using a Droid Bionic, android version 2.3.4 and this is on the default 
> virtual keyboard. Ampersand is the only character affected as far as i can tell.

Comment 1

[Aaron Train [:aaronmt]]

I've got a Droid Bionic at the Toronto office. I can verify this for you on Thursday if need be.

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Aaron Train [:aaronmt] from comment #1)
> I've got a Droid Bionic at the Toronto office. I can verify this for you on
> Thursday if need be.

Thanks, Aaron. I don't have a Droid Bionic, so I was trying to track one down. :)

Comment 3

[Chris Peterson [:cpeterson]]

I haven't reproduced this bug yet, but it should probably be a 14.0.1 soft blocker. Some keyboards can't type '&' if it is SHIFT+7.

This bug is a regression from bug 755517, where I needed to remap ALT+7 to SHIFT+7.

Comment 4

[Aaron Train [:aaronmt]]

Yes, I can reproduce this simply enough by visiting Gmail and tapping on '&' in the password field and out comes a '7'.

Comment 5

[Chris Peterson [:cpeterson]]

This is a critical bug because some people can't enter passwords containing '&' characters!

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

We need to make sure work is progressing on this bug. Chris should bring in Brian to help out and keep it moving forward.

Comment 7

[Aaron Train [:aaronmt]]

Confirming that non-password masked fields are affected too; simply used Google Search field and SUMO's Ask a Question field. & -> 7.

Comment 8

[Aaron Train [:aaronmt]]

Tested a fennec build in-channel of Chris's and it fixes the issue on the Droid Bionic.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #8)
> Tested a fennec build in-channel of Chris's and it fixes the issue on the
> Droid Bionic.

Does it regress the fix in bug 755517?

Comment 10

[Aaron Train [:aaronmt]]

(In reply to Mark Finkle (:mfinkle) from comment #9)
> Does it regress the fix in bug 755517?
No.

Comment 11

[Chris Peterson [:cpeterson]]

Attachment: fix-gingerbread-ampersand.patch

Send '&' as composition string because some Gingerbread VKBs incorrectly map '&' key events.

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

r=blassey

not marking the patch because this bug report is exhibiting a bug in bugzilla that some of the bugzilla maintainers have been trying to get a look at.

Comment 13

[Brian Nicholson (:bnicholson)]

Oops, just saw comment 12 - hope I didn't ruin anything.

Comment 14

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/edd37b3c169d

Comment 15

[Chris Peterson [:cpeterson]]

Comment on attachment 637977 [details] [diff] [review]
fix-gingerbread-ampersand.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 755517
User impact if declined: Some Gingerbread users will not be able to type '&' which sucks if their passwords include '&'!
Testing completed (on m-c, etc.): local builds
Risk to taking this patch (and alternatives if risky): Low risk because this code path ONLY affects Froyo and Gingerbread devices when they are typing '&'.
String or UUID changes made by this patch:

Comment 16

[Chris Peterson [:cpeterson]]

Brian, I'll be on PTO next week. Do you mind uplifting this patch to Aurora and Beta after it's approved? I'd like to get this fix into 14.0.1.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/edd37b3c169d

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 637977 [details] [diff] [review]
fix-gingerbread-ampersand.patch

Approved, we definitely want people on those systems to be able to use '&' how they need to.  Please land to tip of mozilla-beta so it can go out in 14.0.1

Comment 19

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/ea7cf5d5e89b
http://hg.mozilla.org/releases/mozilla-beta/rev/c0ff78dd034d

Comment 20

[Paul Feher]

Verified/fixed on:
Htc Desire Z (2.3.3) - default VKB and Hacker's keyboard 
Using:
Nightly Fennec 16.0a1 (2012-07-02)

The issue is still reproducible for both  Aurora 16.0a2 (2012-07-02) and Firefox Mobile 14 beta 10 build2. Waiting for the patch to land in Aurora and Beta to mark this verified/fixed.

Comment 21

[Aaron Train [:aaronmt]]

Paul,

You would need to verify this on the Droid Bionic ......

Comment 22

[Paul Feher]

Verified/fixed on:
Nightly Fennec 16.0a1 (2012-07-03)
Aurora Fennec 15.0a2 (2012-07-03)
Using:
Droid Bionic (2.3.4) - default VKB

The issue is still for Firefox Beta 14.0b10 . Waiting for the patch to land in Beta to mark this verified/fixed.

Comment 23

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 637977 [details] [diff] [review]
fix-gingerbread-ampersand.patch

Review of attachment 637977 [details] [diff] [review]:
-----------------------------------------------------------------

r=blassey

Comment 24

[Paul Feher]

Verified/fixed on:
Firefox Beta 14.0b11 (2012-07-05)
Using:
Droid Bionic (2.3.4) - default VKB