Last Comment Bug 768736 - Define constants of native virtual keycodes for nsIDOMWindowUtils::SendNativeKeyEvent() users
: Define constants of native virtual keycodes for nsIDOMWindowUtils::SendNative...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan)
:
Mentors:
Depends on: 764285
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-26 18:16 PDT by Masayuki Nakano [:masayuki] (Mozilla Japan)
Modified: 2012-06-27 03:34 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (219.04 KB, patch)
2012-06-26 18:16 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan)
roc: review+
Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-06-26 18:16:55 PDT
Created attachment 636960 [details] [diff] [review]
Patch

Using numbers for the parameter of nsIDOMWindowUtils::SendNativeKeyEvent() is not easy to read. We should define the constants of native virtual keycodes.
Comment 1 Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-06-26 19:28:00 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/015b304bebd0
Comment 2 Ed Morley [:emorley] 2012-06-27 03:34:25 PDT
https://hg.mozilla.org/mozilla-central/rev/015b304bebd0

Note You need to log in before you can comment on or make changes to this bug.