The default bug view has changed. See this FAQ.

Launch app from shell, close, then launch it from terminal results in no icon showing up in task bar in ubuntu

VERIFIED FIXED in Firefox 16

Status

Firefox Graveyard
Webapp Runtime
P3
normal
VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: jsmith, Unassigned)

Tracking

({regression})

unspecified
Firefox 16
All
Linux
regression
Dependency tree / graph

Details

(Whiteboard: [qa!])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Regression from bug 763358.

Steps from bug 762641:

1) Launch a webapp from the shell (ie, the dash or launcher in unity or the activities overlay in gnome shell)
2) Close the webapp and then launch it from a terminal window (ie, ~/.http\;www.lordofultima.com/webapprt-stub)

Expected:

App launches with correct app icon.

Actual:

App launches without an app icon.

Additional Notes:

See https://bugzilla.mozilla.org/show_bug.cgi?id=762641#c13
(Reporter)

Updated

5 years ago
Hardware: ARM → All
(Reporter)

Updated

5 years ago
Keywords: regression
Thanks, Jason.

Chris, was there a reason to choose gdk_set_program_class over g_set_prgname?

g_set_prgname would also set the name class hint, which is the "formal name of the application that should be used when retrieving the application's resources from the resource database", but it's hard to guess the modern effects of these ancient properties.
Blocks: 763358
Often the name field of the class hint gets overridden by a windowtype attribute of the XUL window anyway, so perhaps it's more a question of whether the binary name or the app name is more suitable for GLib, if it matters.
(Reporter)

Updated

5 years ago
Priority: -- → P3

Comment 3

5 years ago
There wasn't really any particular reason for choosing gdk_set_program_class over g_set_prgname, other than the former being a more direct way of achieving the same result. g_set_prgname should work too, but I want to have a quick look in glib at where this names is used, just to make sure it doesn't break anything else.
(Reporter)

Updated

5 years ago
Blocks: 762641
Created attachment 637826 [details] [diff] [review]
use g_set_prgname

Looks like this fixes the problem.
However sometimes when you launch an application from the terminal, for a second you get two icons on the Launcher.

Comment 5

5 years ago
Yes, g_set_prgname should be fine here. The places it gets used in glib and gtk are either not used by us, or they don't care what the name is (or both)
(Reporter)

Updated

5 years ago
QA Contact: jsmith
Attachment #637826 - Flags: review?(karlt)
Attachment #637826 - Flags: review?(karlt) → review+
Keywords: checkin-needed
Comment on attachment 637826 [details] [diff] [review]
use g_set_prgname

https://hg.mozilla.org/integration/mozilla-inbound/rev/06756c4481d5
Attachment #637826 - Flags: checkin+
Keywords: checkin-needed
(Reporter)

Updated

5 years ago
Whiteboard: [qa+]
(Reporter)

Comment 7

5 years ago
(In reply to Marco Castelluccio from comment #4)
> Created attachment 637826 [details] [diff] [review]
> use g_set_prgname
> 
> Looks like this fixes the problem.
> However sometimes when you launch an application from the terminal, for a
> second you get two icons on the Launcher.

Can you still reproduce this with this patch applied? If so, can you file a bug for this?
https://hg.mozilla.org/mozilla-central/rev/06756c4481d5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
(In reply to Jason Smith [:jsmith] from comment #7)
> Can you still reproduce this with this patch applied? If so, can you file a
> bug for this?

Can't reproduce anymore. I'll file a new bug in case this will present again.
(Reporter)

Updated

5 years ago
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
(Assignee)

Updated

a year ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.