769015 - deterministicgc() causes a leak

Status: RESOLVED FIXED

Description

[Jesse Ruderman]

Created attachment 637208 [details]
testcase

1. Install https://www.squarefree.com/extensions/domFuzzLite3.xpi
2. Run a debug build of Firefox with XPCOM_MEM_LEAK_LOG=2
3. Load the testcase.
4. Quit Firefox.

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5cdbeae14405&tochange=5b3bf49ce3cf

Comment 1

[Jesse Ruderman]

Created attachment 637209 [details]
leak log

Comment 2

[Jesse Ruderman]

It might be best to fix the crash discovered in bug 770218 before fixing this leak.

Comment 3

[Bill McCloskey (:billm)]

Created attachment 686815 [details] [diff] [review]
fix

This regressed when I made a separate GC reason for shutdown CCs.

Comment 4

[Bill McCloskey (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/257f949e15fa

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/257f949e15fa

Comment 6

[Jesse Ruderman]

Comment on attachment 686815 [details] [diff] [review]
fix

> This regressed when I made a separate GC reason for shutdown CCs.

If this were a switch rather than an "if >", the compiler could have said you were missing a case :)

>-    if (reason > gcreason::DEBUG_GC && reason != gcreason::CC_FORCED)
>+    if (reason > gcreason::DEBUG_GC &&
>+        reason != gcreason::CC_FORCED && reason != gcreason::SHUTDOWN_CC)
>+    {
>         return false;
>+    }