The default bug view has changed. See this FAQ.

pipeline read-timeout rescheduling problem

RESOLVED FIXED in mozilla16

Status

()

Core
Networking: HTTP
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

16 Branch
mozilla16
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
A transaction at the front of a pipeline can be canceled and restarted in a non-pipelined context if it hangs for a very long time - the concern is that the pipelining created a server or intermediary hang somewhere.

Two fixes are necessary to this logic:

1 - the pipeline position of the rescheduled transaction needs to be reset to 0 so that this timer does not apply the next time around. Before we switched SOLO transactions away from using nsHttpPipeline that happened as part of the pipeline scheduling, but now the old value is just inherited so it needs to be reset explicitly.

2 - NET_TIMEOUT needs to be added to the list of conditions for which pipeline response(0) will be retried.
(Assignee)

Comment 1

5 years ago
Created attachment 637507 [details] [diff] [review]
patch 0
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #637507 - Flags: review?(honzab.moz)
Comment on attachment 637507 [details] [diff] [review]
patch 0

Review of attachment 637507 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab.
Attachment #637507 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/10c1a7434e67

the checkin comment accidentally says bug 763312
(Assignee)

Comment 4

5 years ago
changeset:   97971:10c1a7434e67
user:        Patrick McManus <mcmanus@ducksong.com>
date:        Fri Jun 29 14:24:29 2012 -0400
summary:     bug 763312 pipeline position 0 read time rescheduling fixes r=honzab
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.