Last Comment Bug 769262 - pipeline read-timeout rescheduling problem
: pipeline read-timeout rescheduling problem
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: 16 Branch
: x86_64 Linux
-- normal (vote)
: mozilla16
Assigned To: Patrick McManus [:mcmanus]
: Patrick McManus [:mcmanus]
Depends on:
  Show dependency treegraph
Reported: 2012-06-28 07:08 PDT by Patrick McManus [:mcmanus]
Modified: 2012-07-02 05:56 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch 0 (1.72 KB, patch)
2012-06-28 07:30 PDT, Patrick McManus [:mcmanus]
honzab.moz: review+
Details | Diff | Splinter Review

Description User image Patrick McManus [:mcmanus] 2012-06-28 07:08:06 PDT
A transaction at the front of a pipeline can be canceled and restarted in a non-pipelined context if it hangs for a very long time - the concern is that the pipelining created a server or intermediary hang somewhere.

Two fixes are necessary to this logic:

1 - the pipeline position of the rescheduled transaction needs to be reset to 0 so that this timer does not apply the next time around. Before we switched SOLO transactions away from using nsHttpPipeline that happened as part of the pipeline scheduling, but now the old value is just inherited so it needs to be reset explicitly.

2 - NET_TIMEOUT needs to be added to the list of conditions for which pipeline response(0) will be retried.
Comment 1 User image Patrick McManus [:mcmanus] 2012-06-28 07:30:23 PDT
Created attachment 637507 [details] [diff] [review]
patch 0
Comment 2 User image Honza Bambas (:mayhemer) 2012-06-29 09:46:07 PDT
Comment on attachment 637507 [details] [diff] [review]
patch 0

Review of attachment 637507 [details] [diff] [review]:

Comment 3 User image Patrick McManus [:mcmanus] 2012-06-29 11:54:18 PDT

the checkin comment accidentally says bug 763312
Comment 4 User image Patrick McManus [:mcmanus] 2012-07-02 05:56:41 PDT
changeset:   97971:10c1a7434e67
user:        Patrick McManus <>
date:        Fri Jun 29 14:24:29 2012 -0400
summary:     bug 763312 pipeline position 0 read time rescheduling fixes r=honzab

Note You need to log in before you can comment on or make changes to this bug.