Closed Bug 769262 Opened 10 years ago Closed 10 years ago

pipeline read-timeout rescheduling problem

Categories

(Core :: Networking: HTTP, defect)

16 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

Attachments

(1 file)

A transaction at the front of a pipeline can be canceled and restarted in a non-pipelined context if it hangs for a very long time - the concern is that the pipelining created a server or intermediary hang somewhere.

Two fixes are necessary to this logic:

1 - the pipeline position of the rescheduled transaction needs to be reset to 0 so that this timer does not apply the next time around. Before we switched SOLO transactions away from using nsHttpPipeline that happened as part of the pipeline scheduling, but now the old value is just inherited so it needs to be reset explicitly.

2 - NET_TIMEOUT needs to be added to the list of conditions for which pipeline response(0) will be retried.
Attached patch patch 0Splinter Review
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #637507 - Flags: review?(honzab.moz)
Comment on attachment 637507 [details] [diff] [review]
patch 0

Review of attachment 637507 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab.
Attachment #637507 - Flags: review?(honzab.moz) → review+
changeset:   97971:10c1a7434e67
user:        Patrick McManus <mcmanus@ducksong.com>
date:        Fri Jun 29 14:24:29 2012 -0400
summary:     bug 763312 pipeline position 0 read time rescheduling fixes r=honzab
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.