769357 - Implement <input type=date> min attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Raphael Catolino (:raphc)]

Attachment: patch

This patch applies on top of the one in bug 769355.

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 645694 [details] [diff] [review]
patch

Review of attachment 645694 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +4597,5 @@
> +        double min = GetMinAsDouble();
> +        MOZ_ASSERT(!MOZ_DOUBLE_IS_NaN(min));
> +
> +        minStr.AppendFloat(min);
> +      } else {

else if (mType == NS_FORM_INPUT_DATE)
and:
} else {
MOZ_NOTREACHED();
}

::: content/html/content/test/forms/test_min_attribute.html
@@ +151,5 @@
> +
> +    input.min = '0050-01-01';
> +    checkValidity(input, true, apply, apply);
> +
> +    input.val = '0049-01-01';

input.value

Comment 3

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 650141 [details] [diff] [review]
patch

Review of attachment 650141 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +1257,5 @@
>    GetAttr(kNameSpaceID_None, nsGkAtoms::min, minStr);
>  
> +  double min;
> +  bool result = ConvertStringToNumber(minStr, min);
> +  return result ? min : MOZ_DOUBLE_NaN();

Could be:
return ConvertStringToNumber(minStr, min) ? min : MOZ_DOUBLE_NaN();

@@ +4625,5 @@
> +        minStr.AppendFloat(min);
> +      } else if (mType == NS_FORM_INPUT_DATE) {
> +        GetAttr(kNameSpaceID_None, nsGkAtoms::min, minStr);
> +      } else {
> +        NS_NOTREACHED("Invalid input type");

nit: change the error message to "Unexpected input type".

Comment 5

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 6

[Raphael Catolino (:raphc)]

Attachment: patch

Updated patch.

Comment 7

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/5705bb322879

Comment 8

[Florian Scholz (Open Web Docs)]

See bug 866440 for documentation.