about:newaddon should scale better with multiple add-ons

NEW
Assigned to

Status

()

Toolkit
Add-ons Manager
5 years ago
3 years ago

People

(Reporter: Unfocused, Assigned: sachin)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

At the moment, if there are multiple addons detected as requiring about:newaddon to enable them, we open a tab for every add-on. This can especially be a lot of addons if the DB becomes corrupt. Unfortunately, so many tabs can feel very overwhelming.

I wonder if we can make that scale better, by displaying multiple addons in one about:newaddon instance.

Updated

4 years ago
Duplicate of this bug: 879473
Assignee: nobody → sachinhosmani2
(Assignee)

Updated

4 years ago
Depends on: 834385
Sachin, let's ignore the dependency on bug 834385 and create a prototype that doesn't include vendor comments for now. We need to figure out what to do with bug 834385, and that might take some time.
(Assignee)

Comment 3

4 years ago
Created attachment 773335 [details]
New opt-in screen screenshot

Yes, I have been working on creating a prototype.
I've been able accomplish the functional aspects of the new opt-in screen.
This is what it looks like. It's basically a richlistbox of a fixed size that holds all the add-on items. The about:newaddon URL format has been modified to support multiple add-ons.
Please give feedback.
(Assignee)

Comment 4

4 years ago
Created attachment 774180 [details] [diff] [review]
patch
(Assignee)

Updated

4 years ago
Attachment #773335 - Flags: feedback?
I would only move the "Check the add-ons..." text so that it is right below the listbox and it aligns with its left edge. If that text is longer (like, in another language), it should wrap at the right edge of the listbox. So, pretty much like how the text above the listbox looks like.

Another nit: the warning icon looks stretched vertically.

Other than that, the listbox looks like the right solution.
Attachment #773335 - Flags: feedback? → feedback+
(Assignee)

Comment 6

4 years ago
Created attachment 779132 [details]
screen (2)

I've made the changes that Jorge mentioned.
And yes, the description "Check the add-ons..." gets wrapped if it is longer in another language.
Attachment #773335 - Attachment is obsolete: true
Attachment #779132 - Flags: feedback?
(Assignee)

Updated

4 years ago
Attachment #779132 - Attachment is patch: false
Attachment #779132 - Attachment mime type: text/plain → image/png
Comment on attachment 779132 [details]
screen (2)

Looks good to me! Can you attach the latest version of the patch and request UX review?
Attachment #779132 - Flags: feedback? → feedback+
(Assignee)

Comment 8

4 years ago
Created attachment 779893 [details] [diff] [review]
patch (2)
Attachment #774180 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Attachment #779132 - Flags: review?(ux-review)
(Assignee)

Comment 9

4 years ago
Created attachment 779912 [details] [diff] [review]
patch (3)

Fixed a few small mistakes in patch(2).
Attachment #779893 - Attachment is obsolete: true
Duplicate of this bug: 886661
Blocks: 886662
Comment on attachment 779132 [details]
screen (2)

Redirecting review since it was dead in the water when assigned to ux-review@.
Attachment #779132 - Flags: review?(ux-review) → review?(dhenein)
Attachment #779132 - Flags: review?(dhenein)
You need to log in before you can comment on or make changes to this bug.