Closed Bug 769533 Opened 8 years ago Closed 8 years ago

get rid of AppendwithConversion

Categories

(Core :: String, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Attachment #637775 - Flags: review?(dbaron)
Attachment #637776 - Flags: review?(dbaron)
I can review this early next week if you like, Makoto.  My review load is probably lower than dbaron's.
That's fine.  I think the main interesting thing to investigate is whether the removal of the null-check is safe for all of the char*/PRUnichar* callers.
Attachment #637775 - Flags: review?(dbaron) → review?(justin.lebar+bug)
Attachment #637776 - Flags: review?(dbaron) → review?(justin.lebar+bug)
Comment on attachment 637775 [details] [diff] [review]
replace AppendWithConversion with others

># HG changeset patch
># Parent 2791940fb1ff454482ed91a76c9865c14b7b924e
>
>Part 1: replace AppendWithConversion with others
>
>dbaron: I think the main interesting thing to investigate is whether the
>removal of the null-check is safe for all of the char*/PRUnichar* callers.

I'm not sure what you mean -- AppendASCIItoUTF16 and LossyAppendUTF16toASCII both do null-checks on the pointers, so we should be good, right?

r=me pending dbaron's confirming that I'm not missing something here.
Attachment #637775 - Flags: review?(justin.lebar+bug) → review+
Attachment #637776 - Flags: review?(justin.lebar+bug) → review+
(In reply to Justin Lebar [:jlebar] from comment #4)
> I'm not sure what you mean -- AppendASCIItoUTF16 and LossyAppendUTF16toASCII
> both do null-checks on the pointers, so we should be good, right?

Oh, right.
You need to log in before you can comment on or make changes to this bug.