get rid of AppendwithConversion

RESOLVED FIXED in mozilla16

Status

()

Core
String
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 637775 [details] [diff] [review]
replace AppendWithConversion with others
Attachment #637775 - Flags: review?(dbaron)
(Assignee)

Comment 1

5 years ago
Created attachment 637776 [details] [diff] [review]
get rid of AppendWithConversion
(Assignee)

Updated

5 years ago
Attachment #637776 - Flags: review?(dbaron)
I can review this early next week if you like, Makoto.  My review load is probably lower than dbaron's.
That's fine.  I think the main interesting thing to investigate is whether the removal of the null-check is safe for all of the char*/PRUnichar* callers.
Attachment #637775 - Flags: review?(dbaron) → review?(justin.lebar+bug)
Attachment #637776 - Flags: review?(dbaron) → review?(justin.lebar+bug)
Comment on attachment 637775 [details] [diff] [review]
replace AppendWithConversion with others

># HG changeset patch
># Parent 2791940fb1ff454482ed91a76c9865c14b7b924e
>
>Part 1: replace AppendWithConversion with others
>
>dbaron: I think the main interesting thing to investigate is whether the
>removal of the null-check is safe for all of the char*/PRUnichar* callers.

I'm not sure what you mean -- AppendASCIItoUTF16 and LossyAppendUTF16toASCII both do null-checks on the pointers, so we should be good, right?

r=me pending dbaron's confirming that I'm not missing something here.
Attachment #637775 - Flags: review?(justin.lebar+bug) → review+
Attachment #637776 - Flags: review?(justin.lebar+bug) → review+
(In reply to Justin Lebar [:jlebar] from comment #4)
> I'm not sure what you mean -- AppendASCIItoUTF16 and LossyAppendUTF16toASCII
> both do null-checks on the pointers, so we should be good, right?

Oh, right.
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c3fc27e9746
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a96f6193e75
Assignee: nobody → m_kato
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/3c3fc27e9746
https://hg.mozilla.org/mozilla-central/rev/5a96f6193e75
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.