769569 - Check that navigator.id.request was called as a result of user input

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Matthew N. [:MattN]]

"#### navigator.id.request(<options>);
…This function must be invoked from within a click handler."

We would need something like nsEventStateManager::IsHandlingUserInput on a scriptable interface (such as DOMWindowUtils).

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

On b2g, sounds like we want the same protections that are implemented for window.open - to know that it was the result of a touch.

Comment 2

[Mounir Lamouri (:mounir)]

We can use popup blocker mechanism or nsEventStateManager::IsHandlingUserInput.

Comment 3

[Andrew Overholt [:overholt]]

Can you take this, Mounir?

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 5

[Ben Adida [:benadida]]

Comment on attachment 668477 [details] [diff] [review]
Patch

awesome, looks great, thanks Mounir!

Comment 6

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7fa297880c5
(I've added some test fixes)

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b7fa297880c5

Comment 8

[Mounir Lamouri (:mounir)]

Pushed to mozilla-aurora because it is blocking basecamp.
https://hg.mozilla.org/releases/mozilla-aurora/rev/dee2eda3a3ec