798298 - Allow chrome JS code to know if it is being called as a result of a user input event

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Mounir Lamouri (:mounir)]

Currently, there are two ways to make sure some features are called when there is a real user action that might have requested it:
- the popup manager (in nsPIDOMWindow and nsGlobalWindow);
- nsEventStateManager::IsHandlingUserInput().

None of them (AFAIK) are available to JS but bug 794407 and bug 769569 needs a mechanism or the other to make sure those features are not abused.

I think we should expose something trough a component.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 668475 [details] [diff] [review]
Patch


>+  *aHandlingUserInput = GetPresContext()->EventStateManager()->IsHandlingUserInput();

GetPresContext() needs null check.

>+  /**
>+   * Returns if the current code is runned from a user input handling.
returns what?
And 'is run'

But perhaps:
Returns true if user input is being handled.

>+   *
>+   * This is calling nsEventStateManager::IsHandlingUserInput().
This calls nsEventStateManager::IsHandlingUserInput()

>+   */
>+  readonly attribute boolean handlingUserInput;
isHandlingUserInput

Comment 3

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/055d18bfa169

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/055d18bfa169

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Couldn't the homescreen app simply not display itself? I.e. it's the homescreen app which is listing all the apps, it can simply choose to not skip displaying anything when it sees its own manifestURL

Comment 6

[Mounir Lamouri (:mounir)]

Jonas, I guess you meant to comment in bug 794407.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yes. Thanks!

Comment 8

[Mounir Lamouri (:mounir)]

Pushed in mozilla-aurora, because it is blocking basecamp.
https://hg.mozilla.org/releases/mozilla-aurora/rev/cc22c3a6f9ed