769667 - Latest approved revision is not always the current revision

Status: REOPENED

(support.mozilla.org :: Knowledge Base Software, defect, P2)

Description

[Verdi [:verdi] Best to slack me]

Attachment: example of the history page

Sometimes when approving a new revision of an article, the revision shows up in the history as approved but the old revision remains the current revision. This seems to be more of an annoyance than an actual problem as it seems to fix itself in about 15 min or so but I thought I should report it because something has obviously changed.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

This is probably a cache invalidation issue.

Comment 2

[Scoobidiver (away)]

I can reproduce: https://support.mozilla.org/fr/kb/barre-outils-google-pas-compatible-firefox/history

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

This is some weird caching issue that always seems to fix itself in a few minutes.

Comment 5

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

i have seen this! it is indeed caching. if it's not caching, please re-open

Comment 6

[Alice Wyman]

Reopen? This bug can result in editing errors. See bug 1470200 comment 22 as an example.

Comment 7

[Alice Wyman]

(In reply to Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland from comment #5)
> i have seen this! it is indeed caching. if it's not caching, please re-open

https://support.mozilla.org/en-US/kb/import-bookmarks-internet-explorer-or-microsoft-ed/history (the example in bug 1470200 comment 22) had a "Current" status for revision 163373 by Lan (created and approved Jul 7, 2018) even though two later revisions, 163404 and 163405 (also dated Jul 7, 2018) had also been approved. The "Current" status for the earlier revision 163373 continued until today, when another revision was approved. 

Reopening, since the above example wasn't "some weird caching issue that always seems to fix itself in a few minutes".

Comment 8

[Alice Wyman]

Attachment: CurrentVersionKBsoftwareBug769667.png

https://support.mozilla.org/en-US/kb/make-firefox-your-default-browser is another example where the current version isn't the last approved version, as shown in the article history page, https://support.mozilla.org/en-US/kb/make-firefox-your-default-browser/history (I attached a screenshot in case someone updates the article).  

The last approved version added {for win10} tags around the "Video Available" note.  When you view the article,  the "Video Available" is shown for all operating systems, not just win10. When you go to edit the article, the older "current" version, without the showfor win10 tags, is brought up.

Comment 9

[Alice Wyman]

This came up again. See https://support.mozilla.org/en-US/kb/disconnect-your-firefox-account-fire-tv/history

Screenshot (from the related discussion thread): https://support.mozilla.org/en-US/gallery/image/35032

Comment 10

[Alice Wyman]

Attachment: SuMoEmptyEdit-bug769667.png

(from comment #9)

This came up again. See https://support.mozilla.org/en-US/kb/disconnect-your-firefox-account-fire-tv/history

Screenshot (from the related discussion thread): https://support.mozilla.org/en-US/gallery/image/35032

This was never fixed. The latest approved revision is still not the current revision. I submitted an empty edit based on the approved revision.

Comment 11

[Emil Ghitta, QA [:emilghitta]]

Hey Verdi & Alice!

Is this issue still reproducible on your end? I tried to reproduce a couple of times but failed to do so, for me the latest approved revision is the current revision.

Thanks!

Comment 12

[Alice Wyman]

There are no steps to reproduce the issue since it happens after approving a revision for some, but not all articles. I have no problem with closing this bug as WORKSFORME. We can reopen this bug the next time the issue reappears.

Comment 13

[Verdi [:verdi] Best to slack me]

I haven't approved an article in years so I have no idea.

Comment 14

[Emil Ghitta, QA [:emilghitta]]

Thanks, Verdi & Alice!

Let's mark this as WORKSFORME for now. Feel free to reopen if this issue reappears!

Comment 15

[Alice Wyman]

See https://support.mozilla.org/en-US/kb/firefox-accounts-renamed-mozilla-accounts/discuss/11723#post-25744 and https://support.mozilla.org/en-US/kb/firefox-accounts-renamed-mozilla-accounts/history

I can't be 100% certain since a new revision has since been approved which is now the current revision but it looks like this is still happening. What I thought was a small change to update the search summary was not based on the last approved revision but on the one before.

Comment 16

[Alice Wyman]

Attachment: SUMO-Nov7,2023LastApprovedVersionNotCurrentVersion.png

Here is a screenshot of the History page for a minor edit to an article I approved this morning,
https://support.mozilla.org/en-US/kb/will-firefox-work-my-mobile-device
...showing that the approved version is not the current version.
https://support.mozilla.org/en-US/kb/will-firefox-work-my-mobile-device/history

Here is the revision information:

Revision id: 269861
Created: Nov 7, 2023, 10:01:47 AM
Creator: Mozinet
Comment: added a note formatting
Reviewed: Yes
Reviewed: Nov 7, 2023, 11:17:17 AM
Reviewed by: AliceWyman
Is approved? Yes
Is current revision? No
Ready for localization: No

Comment 17

[Alice Wyman]

The last approved revision for https://support.mozilla.org/en-US/kb/will-firefox-work-my-mobile-device is still not the current revision, as shown on its History page, https://support.mozilla.org/en-US/kb/will-firefox-work-my-mobile-device/history

The article itself doesn't show the note formatting that was approved on Nov 7, 2023 and the Edit Article link under Editing Tools opens the previously-approved Nov 1, 2023 revision for editing:
Revision id: 268958
Created: Nov 1, 2023, 2:47:22 AM
Creator: Mark Heijl
Comment: minor edits
Reviewed: Yes
Reviewed: Nov 1, 2023, 3:33:49 PM
Reviewed by: AliceWyman
Is approved? Yes
Is current revision? Yes
Ready for localization: No

I resubmitted the last approved Nov 7, 2023 revision by Mozinet and it's pending review.