Unnecessary kungFuDeathGrips in the idle API code

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: bsurender)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Since we removed the AddRef/Release across timer callbacks, those kungFuDeathGrips should be unnecessary.

http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.482
http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.502
http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.707
(Assignee)

Comment 1

5 years ago
Created attachment 640023 [details] [diff] [review]
OS Idle API kungFuDeathGrips and parentheses removed (bug 769722)

This patch addresses the kung fu death grip and bug 769722, unecessary parentheses.

Loaded to try on bsurender@mozilla.com – Thu Jul 5 16:22:30 2012 PDT. Just got all of the test results for changeset 80e15cb53444.

https://tbpl.mozilla.org/?tree=Try&rev=80e15cb53444

Please look at adjacent green test results for tests that failed. Comments also added for Android test failures.
Attachment #640023 - Flags: review?(jst)
Comment on attachment 640023 [details] [diff] [review]
OS Idle API kungFuDeathGrips and parentheses removed (bug 769722)

r=jst
Attachment #640023 - Flags: review?(jst) → review+
(Assignee)

Updated

5 years ago
Attachment #640023 - Flags: checkin?(jst)
http://hg.mozilla.org/integration/mozilla-inbound/rev/4c42f5fdc769
https://hg.mozilla.org/mozilla-central/rev/4c42f5fdc769
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Attachment #640023 - Flags: checkin?(jst)
You need to log in before you can comment on or make changes to this bug.