Closed
Bug 769723
Opened 13 years ago
Closed 13 years ago
Unnecessary kungFuDeathGrips in the idle API code
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: khuey, Assigned: bsurender)
References
Details
Attachments
(1 file)
|
2.70 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
Since we removed the AddRef/Release across timer callbacks, those kungFuDeathGrips should be unnecessary.
http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.482
http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.502
http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.707
This patch addresses the kung fu death grip and bug 769722, unecessary parentheses.
Loaded to try on bsurender@mozilla.com – Thu Jul 5 16:22:30 2012 PDT. Just got all of the test results for changeset 80e15cb53444.
https://tbpl.mozilla.org/?tree=Try&rev=80e15cb53444
Please look at adjacent green test results for tests that failed. Comments also added for Android test failures.
Attachment #640023 -
Flags: review?(jst)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 640023 [details] [diff] [review]
OS Idle API kungFuDeathGrips and parentheses removed (bug 769722)
r=jst
Attachment #640023 -
Flags: review?(jst) → review+
Attachment #640023 -
Flags: checkin?(jst)
|
|
||
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
|
||
Updated•13 years ago
|
Attachment #640023 -
Flags: checkin?(jst)
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•