76975 - [MLK] Leaking C strings in nsNSSComponent::ConfigureInternalPKCS11Token()

Status: VERIFIED WONTFIX

(Core Graveyard :: Security: UI, defect, P3)

Description

[Patrick C. Beard]

All the calls to GetPK11String() in this method allocate strings. The call to  
PK11_ConfigurePKCS11() at the bottom of the method evidently copies all of those 
strings, thus all of the allocated strings leak. The URL above points to just one 
of the lines where a leaked string is allocated.

Comment 1

[Javier Delgadillo]

This is a one time leak caused by NSS not freeing the strings passed in for
intializing the token names.  A possible work around is to declare our own
global static char arrays and populate and pass it to the PK11 libraries.

This is a one time less than 300 bytes.

Comment 2

[David P. Drinan]

->p3

Comment 3

[Stephane Saux]

Mass reassigning target to 2.1

Comment 4

[Stephane Saux]

remove nsenterprise.

Comment 5

[Stephane Saux]

Moving all P3 and P4 bugs targetted to 2.1 to future.

Comment 6

[Wan-Teh Chang]

Changed the QA contact to Bishakha.

Comment 7

[Kai Engert (:KaiE:)]

This is not a PSM bug.

PSM by itself is not leaking (at least it does no longer leak, if it ever leaked
in the past).

PSM passes internal buffers of automatic strings to PK11_ConfigurePKCS11. It
will free the temporaray strings after the call.

If you think NSS is leaking and should free its strings on shutdown, please
reopen and change this into a NSS bug.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think this was fixed in another bug (perhaps even one filed after this one).

Comment 9

[John Unruh]

Verified.