The default bug view has changed. See this FAQ.

Make "Import from Android" use MultiChoicePreference

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
General
--
enhancement
VERIFIED FIXED
5 years ago
8 months ago

People

(Reporter: gcp, Assigned: gcp)

Tracking

Trunk
Firefox 16
ARM
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox15- fixed, firefox16 verified, firefox17 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bug 754335 added a MultiChoicePreference dialog. The "Import from Android" in bug 710330 already had a lightweight version of that. We should change the latter to use the former.
(Assignee)

Updated

5 years ago
Depends on: 754335, 710330
(Assignee)

Updated

5 years ago
Duplicate of this bug: 770355
(Assignee)

Comment 2

5 years ago
Created attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference
Assignee: nobody → gpascutto
Attachment #641466 - Flags: review?(bnicholson)
(Assignee)

Updated

5 years ago
tracking-firefox15: --- → ?
Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

Too bad this seems to just complicate your code more. Maybe MultiChoicePreference should return a Map instead of different arrays.
Attachment #641466 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 4

5 years ago
More functionality for approximately the same amount of code isn't much of a complication :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f4ad785cca8
(Assignee)

Comment 5

5 years ago
Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 710330
User impact if declined: Settings dialog lost on rotation
Testing completed (on m-c, etc.): Just landed on m-c
Risk to taking this patch (and alternatives if risky): Broken UI? Low risk.
Attachment #641466 - Flags: approval-mozilla-aurora?
(In reply to Gian-Carlo Pascutto (:gcp) from comment #5)
> Comment on attachment 641466 [details] [diff] [review]
> Patch 1. Use MultiChoicePreference
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): Bug 710330
> User impact if declined: Settings dialog lost on rotation
> Testing completed (on m-c, etc.): Just landed on m-c
> Risk to taking this patch (and alternatives if risky): Broken UI? Low risk.

So does this have string changes then?
https://hg.mozilla.org/mozilla-central/rev/1f4ad785cca8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
(Assignee)

Comment 8

5 years ago
>So does this have string changes then?

No, it's a functional change in existing UI.

Updated

5 years ago
Attachment #641466 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
tracking-firefox15: ? → -
(Assignee)

Comment 9

5 years ago
Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

[Approval Request Comment]
Same as for the approval-aurora that already got a +. I forgot to land this patch on Aurora.
Attachment #641466 - Flags: approval-mozilla-beta?
Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

Mobile only, so approving for Beta landing.
Attachment #641466 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox15: --- → affected
status-firefox16: --- → fixed
(Assignee)

Comment 11

5 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/62a1df5fee45
status-firefox15: affected → fixed
aurora?
Status: RESOLVED → VERIFIED
status-firefox17: --- → verified
Keywords: checkin-needed
(Assignee)

Comment 13

5 years ago
It's already in Aurora. The patch landed in Nightly, and didn't get in Aurora before the migration date (16th July), so it's in Aurora now because it was in Nightly, and was missing in Beta because it wasn't in Aurora (until comment 11 added it to beta after the migration).
Keywords: checkin-needed

Updated

5 years ago
status-firefox16: fixed → verified
You need to log in before you can comment on or make changes to this bug.