Closed Bug 769896 Opened 7 years ago Closed 7 years ago

Make "Import from Android" use MultiChoicePreference

Categories

(Firefox for Android :: General, enhancement)

ARM
Android
enhancement
Not set

Tracking

()

VERIFIED FIXED
Firefox 16
Tracking Status
firefox15 - fixed
firefox16 --- verified
firefox17 --- verified

People

(Reporter: gcp, Assigned: gcp)

References

Details

Attachments

(1 file)

Bug 754335 added a MultiChoicePreference dialog. The "Import from Android" in bug 710330 already had a lightweight version of that. We should change the latter to use the former.
Depends on: 754335, 710330
Duplicate of this bug: 770355
Assignee: nobody → gpascutto
Attachment #641466 - Flags: review?(bnicholson)
Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

Too bad this seems to just complicate your code more. Maybe MultiChoicePreference should return a Map instead of different arrays.
Attachment #641466 - Flags: review?(bnicholson) → review+
More functionality for approximately the same amount of code isn't much of a complication :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f4ad785cca8
Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 710330
User impact if declined: Settings dialog lost on rotation
Testing completed (on m-c, etc.): Just landed on m-c
Risk to taking this patch (and alternatives if risky): Broken UI? Low risk.
Attachment #641466 - Flags: approval-mozilla-aurora?
(In reply to Gian-Carlo Pascutto (:gcp) from comment #5)
> Comment on attachment 641466 [details] [diff] [review]
> Patch 1. Use MultiChoicePreference
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): Bug 710330
> User impact if declined: Settings dialog lost on rotation
> Testing completed (on m-c, etc.): Just landed on m-c
> Risk to taking this patch (and alternatives if risky): Broken UI? Low risk.

So does this have string changes then?
https://hg.mozilla.org/mozilla-central/rev/1f4ad785cca8
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
>So does this have string changes then?

No, it's a functional change in existing UI.
Attachment #641466 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

[Approval Request Comment]
Same as for the approval-aurora that already got a +. I forgot to land this patch on Aurora.
Attachment #641466 - Flags: approval-mozilla-beta?
Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

Mobile only, so approving for Beta landing.
Attachment #641466 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
aurora?
Status: RESOLVED → VERIFIED
Keywords: checkin-needed
It's already in Aurora. The patch landed in Nightly, and didn't get in Aurora before the migration date (16th July), so it's in Aurora now because it was in Nightly, and was missing in Beta because it wasn't in Aurora (until comment 11 added it to beta after the migration).
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.