769896 - Make "Import from Android" use MultiChoicePreference

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Gian-Carlo Pascutto [:gcp]]

Bug 754335 added a MultiChoicePreference dialog. The "Import from Android" in bug 710330 already had a lightweight version of that. We should change the latter to use the former.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Use MultiChoicePreference

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

Too bad this seems to just complicate your code more. Maybe MultiChoicePreference should return a Map instead of different arrays.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

More functionality for approximately the same amount of code isn't much of a complication :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f4ad785cca8

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 710330
User impact if declined: Settings dialog lost on rotation
Testing completed (on m-c, etc.): Just landed on m-c
Risk to taking this patch (and alternatives if risky): Broken UI? Low risk.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to Gian-Carlo Pascutto (:gcp) from comment #5)
> Comment on attachment 641466 [details] [diff] [review]
> Patch 1. Use MultiChoicePreference
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): Bug 710330
> User impact if declined: Settings dialog lost on rotation
> Testing completed (on m-c, etc.): Just landed on m-c
> Risk to taking this patch (and alternatives if risky): Broken UI? Low risk.

So does this have string changes then?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1f4ad785cca8

Comment 8

[Gian-Carlo Pascutto [:gcp]]

>So does this have string changes then?

No, it's a functional change in existing UI.

Comment 9

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

[Approval Request Comment]
Same as for the approval-aurora that already got a +. I forgot to land this patch on Aurora.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 641466 [details] [diff] [review]
Patch 1. Use MultiChoicePreference

Mobile only, so approving for Beta landing.

Comment 11

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-beta/rev/62a1df5fee45

Comment 12

[Aaron Train [:aaronmt]]

aurora?

Comment 13

[Gian-Carlo Pascutto [:gcp]]

It's already in Aurora. The patch landed in Nightly, and didn't get in Aurora before the migration date (16th July), so it's in Aurora now because it was in Nightly, and was missing in Beta because it wasn't in Aurora (until comment 11 added it to beta after the migration).