76993 - images don't show up in documents printed via PostScript

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Christopher Blizzard (:blizzard)]

I tried printing www.mozilla.org and the image banner at the top of the page
shows up as a black area.  Also, trying to print the banner itself doesn't print
anything except the header and footer of the page with the url.  The page is
otherwise white.

Looking at the resulting .ps document it doesn't appear that the image data is
in the postscript file like I would expect it to be.

Comment 1

[Brendan Eich [:brendan]]

important to 0.9?

/be

Comment 2

[Brendan Eich [:brendan]]

Pavlov, you know anything about printing images?

/be

Comment 3

[Stuart Parmenter]

patch coming up.

Comment 4

[Stuart Parmenter]

Attachment: fix for images not printing

Comment 5

[Stuart Parmenter]

I think we should get this in for 0.9.

Comment 6

[Stuart Parmenter]

need r= and sr=

Comment 7

[Stuart Parmenter]

*** Bug 75436 has been marked as a duplicate of this bug. ***

Comment 8

[Roland Mainz]

Pavlov... can you "do" the same fix for Xprint (mozilla/gfx/src/xprint/) print
module, please ?

Comment 9

[Christopher Blizzard (:blizzard)]

What's with this code?

+#if 0
+  sr = *aSrcRect;
+  mTranMatrix->TransformCoord(&sr.x, &sr.y, &sr.width, &sr.height);
+
+  sr.x = aSrcRect->x;
+  sr.y = aSrcRect->y;
+  mTranMatrix->TransformNoXLateCoord(&sr.x, &sr.y);
+#endif


+  // doesn't it seem like we should use more of the params here?
+  // img->Draw(*this, surface, sr.x, sr.y, sr.width, sr.height, dr.x, dr.y,
dr.width, dr.height);

and in the other function, too?  Are we going to need it some time in the
future?  If so, please put the bug number above it.  If not delete it.  Other
than that the code looks fine and I took it around the block for a test drive
and it seemed to work just fine.  I say we ship it!

r/sr=blizzard assuming comments above are addressed.

Comment 10

[Roland Mainz]

blizzard, what should we do with Xprint ? I'd like to get the same patch "in"
0.9 - but my rebuild still needs ~3hours until it is "finished"... ;-(
Need help...

Comment 11

[Stuart Parmenter]

I don't know.  Hyatt was bringing me his postscript book today.. I was gonna
take a look to see if we need them... It seems like we should probably use them
in some manor, I'm just not sure what or if it matters with our current printing
system.

Comment 12

[Stuart Parmenter]

this bug is for postscript printing.  leave xprint out of it.

Comment 13

[tor]

A possible example where ignoring the source rect in drawScaledImage would
lead to incorrect results - a scaled image in a scrolled iframe (so the image
is clipped with a non-zero origin).

Comment 14

[Stuart Parmenter]

right, which is why I put the comments there.  I don't know enough about
postscript to know where exactly the numbers would be used, so I have to do some
research on it.

Comment 15

[Stuart Parmenter]

xprint should be able to print images from my looking at it.  since it uses the
toolkit's image code, it should be fine.  the code for drawing images (for
renderingcontext) is in the baseclass nsRenderingContextImpl which the xprint
nsRenderingContextXP inherits from.  No special code should be needed.  If there
is, lets open another bug.

Comment 16

[Brendan Eich [:brendan]]

Who is module owner or peer, who can r=?

Pav, cite this bug # or a new one in the comment, for the followup research? 
These things don't always get followed up as quickly as the initial checkin for
a milestone would suggest, so a trail of breadcrumbs helps.

/be

Comment 17

[Roland Mainz]

> xprint should be able to print images from my looking at it.  since it uses 
> the toolkit's image code, it should be fine.  the code for drawing images (for
> renderingcontext) is in the baseclass nsRenderingContextImpl which the xprint
> nsRenderingContextXP inherits from. 

This was my conclusion, too...

> No special code should be needed. 

...unfortunately it does not print any images - and I really do not have any
idea _why_ it does not print them...

> If there is, lets open another bug.

I filed bug 77210 for this and assigned it to you as I do not have any idea
where I can look for... ;-(

Comment 18

[Marek Z. Jeziorek]

tor or brendan, could you provide review for this? thanks.

Comment 19

[Brendan Eich [:brendan]]

r=[e-mail], but do what blizzard asked and cite at least *this* bug
in the "more of the params" comment.  And lose the #if 0 noise.

/be

Comment 20

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9

Comment 21

[Stuart Parmenter]

fix checked in.

Comment 22

[sujay]

I cannot verify this for ART images until Bug 4487 is fixed.

Comment 23

[sujay]

art images print fine on windows....