770141 - xpcom/tests/windows/TestRegistrationOrder.cpp fails with Pymake

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: workaround

AFAIK it's because Pymake doesn't match GNU make when it comes to backslash-escaping rules. Attached is a workaround, and I'll file a bug against Pymake shortly.

Comment 1

[Rain [:rain1] (inactive)]

See bug 770181 for the backslash escape bug.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Can we just fix bug 770181?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 638321 [details] [diff] [review]
workaround

Lets just fix pymake.

Comment 4

[Rain [:rain1] (inactive)]

Attachment: sidestep the issue

This is really unfortunate, but I don't know how we could possibly work with backslashes in pymake shells. See bug 770181 comment 3.

That is, unless you think replacing all \ with \\ wouldn't cause problems. I haven't managed to convince myself of that yet.

Comment 5

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ac2d2c7ccb1b

Bug 770181 will cover attempts to work around or fix the core issue.

Comment 6

[Matt Brubeck (:mbrubeck)]

Sorry, I backed this out on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f4f8e1167c9

because of these test failures that appeared after it landed:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13814927&tree=Mozilla-Inbound
Running RegistrationOrder tests...
TEST-UNEXPECTED-FAIL | TestRegular FAILED - cannot create core service
TEST-UNEXPECTED-FAIL | TestJar FAILED - cannot create core service
TEST-UNEXPECTED-FAIL | RegTestOrderC: contract not registered
Finished running RegistrationOrder tests.

Since we didn't get a full set of builds on every push, we don't know for sure that this bug caused the test failures; if it was backed out incorrectly then I will re-land it.

Comment 7

[Rain [:rain1] (inactive)]

Off by one error, fixed and pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/c554e44df724

(I didn't ask for another review because it was a trivial test-only change)

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c554e44df724