Note: There are a few cases of duplicates in user autocompletion which are being worked on.

xpcom/tests/windows/TestRegistrationOrder.cpp fails with Pymake

RESOLVED FIXED in mozilla17

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

Trunk
mozilla17
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 638321 [details] [diff] [review]
workaround

AFAIK it's because Pymake doesn't match GNU make when it comes to backslash-escaping rules. Attached is a workaround, and I'll file a bug against Pymake shortly.
Attachment #638321 - Flags: review?(khuey)
(Assignee)

Updated

5 years ago
Blocks: 593585
(Assignee)

Comment 1

5 years ago
See bug 770181 for the backslash escape bug.
See Also: → bug 770181
Can we just fix bug 770181?
Comment on attachment 638321 [details] [diff] [review]
workaround

Lets just fix pymake.
Attachment #638321 - Flags: review?(khuey) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 644443 [details] [diff] [review]
sidestep the issue

This is really unfortunate, but I don't know how we could possibly work with backslashes in pymake shells. See bug 770181 comment 3.

That is, unless you think replacing all \ with \\ wouldn't cause problems. I haven't managed to convince myself of that yet.
Attachment #638321 - Attachment is obsolete: true
Attachment #644443 - Flags: review?(benjamin)
Attachment #644443 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/ac2d2c7ccb1b

Bug 770181 will cover attempts to work around or fix the core issue.
Assignee: nobody → sagarwal
Status: NEW → ASSIGNED
Sorry, I backed this out on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f4f8e1167c9

because of these test failures that appeared after it landed:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13814927&tree=Mozilla-Inbound
Running RegistrationOrder tests...
TEST-UNEXPECTED-FAIL | TestRegular FAILED - cannot create core service
TEST-UNEXPECTED-FAIL | TestJar FAILED - cannot create core service
TEST-UNEXPECTED-FAIL | RegTestOrderC: contract not registered
Finished running RegistrationOrder tests.

Since we didn't get a full set of builds on every push, we don't know for sure that this bug caused the test failures; if it was backed out incorrectly then I will re-land it.
(Assignee)

Comment 7

5 years ago
Off by one error, fixed and pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/c554e44df724

(I didn't ask for another review because it was a trivial test-only change)

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c554e44df724
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.