770397 - Show file attachments

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[John Karahalis [:openjck]]

We have several bugs related to file attachments (see bug 766741 and its dependencies), but nothing that explicitly mentions showing existing file attachments.

Is this already done? I would test myself but -new is veeeery slow right now.

Comment 1

[David Walsh :davidwalsh]

PR here:

https://github.com/mozilla/kuma/pull/339

Comment 2

[David Walsh :davidwalsh]

More recent PR here:  https://github.com/mozilla/kuma/pull/353

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7ab4ef2ef44d317a76e5406aa0af99e04f2a6273
Adjust the 'attachments' property of Documents to find all files.

This uses pretty simple logic to scan a Document's HTML for both
MindTouch and kuma file URL patterns, and then uses Q objects to build
a correct query to return the corresponding Attachment objects. If no
file URLs are found in the Document, it'll return an empty Attachment
queryset.

fix bug 770397 - Displaying attachments table under document and tags

fix bug 770563 - Show tags and file attachments regardless of TOC

Bugfix: actually wrap the file queries in Q objects.

Changing file URL method

Removing unnecessary filesize() method from AttachmentRevisions model

Fixing merge conflict