770548 - frameworker: pare down exposed API

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: SocialAPI, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

- MozWebSocket and MozBlobBuilder are deprecated
- What are the use cases for Blob/FileReader?
- Why are "location" and "navigator" exposed?

This also simplifies the localStorage test a bit (I had unnecessarily copied the XHR test rather than using makeWorkerURL), and adds tests for timeouts, base64, and a very basic test for websockets.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 638742 [details] [diff] [review]
patch

Oops, filereader/blob are needed in some tests, and I forgot to remove those references. Treat this as a feedback request!

Comment 3

[Shane Caraveo (:mixedpuppy)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #0)
> - MozWebSocket and MozBlobBuilder are deprecated
> - What are the use cases for Blob/FileReader?

MozBlobBuilder is in use, as well as FileReader

> - Why are "location" and "navigator" exposed?

They are part of the W3C Worker api, though they probably should be wrapped, and I believe that "navigator" is a limited version in the Worker.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I just went ahead and landed the additional tests on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/242ce0073d97

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

removes:
- MozWebSocket (all the worker code I've seen handles just having WebSocket)
- "location", since that seems to be unused

MozBlobBuilder and navigator seem to be relied on by some worker code.

This also limits the unwrapping hack to XMLHTTPRequest, since the other functions seem to work without it.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 638868 [details] [diff] [review]
patch

'navigator' should probably be stripped down - the spec says that the only attributes it needs are appName, appVersion, platform, userAgent and onLine.  But I'll call that a nit, so f+

Comment 7

[Asa Dotzler [:asa]]

Is this something we want to get in for v1?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

No, it's not necessary.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

Is this bug still valid?  I think we have the worker API as minimal as we can make it at the moment...

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Yeah, this got resolved in other bugs.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

I guess the only other "obsolete" API that's still left is MozBlobBuilder (bug 736687) - I filed bug 817448 for that.