Closed Bug 770550 Opened 10 years ago Closed 10 years ago

rename FrameWorker.jsm exported symbol (FrameWorker -> getFrameWorkerHandle?)

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 16

People

(Reporter: Gavin, Assigned: Gavin)

Details

Attachments

(1 file, 1 obsolete file)

Since this function isn't a constructor, and the returned object isn't a FrameWorker object, I think it makes sense to change the exported symbol's name.

I picked "getFrameWorkerHandle" because I'd chosen "WorkerHandle" in the previous patch. I'm not particularly attached to that name, though, and it is kind of ugly. Feedback desired!
Attached patch patch (obsolete) — Splinter Review
Attachment #638755 - Flags: review?(mhammond)
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
This has a test fix.
Attachment #638755 - Attachment is obsolete: true
Attachment #638755 - Flags: review?(mhammond)
Attachment #638782 - Flags: review?(mhammond)
Attachment #638782 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a70007cba6bf
Flags: in-testsuite+
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/a70007cba6bf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.