Closed
Bug 770550
Opened 12 years ago
Closed 12 years ago
rename FrameWorker.jsm exported symbol (FrameWorker -> getFrameWorkerHandle?)
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file, 1 obsolete file)
|
12.52 KB,
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
Since this function isn't a constructor, and the returned object isn't a FrameWorker object, I think it makes sense to change the exported symbol's name.
I picked "getFrameWorkerHandle" because I'd chosen "WorkerHandle" in the previous patch. I'm not particularly attached to that name, though, and it is kind of ugly. Feedback desired!
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #638755 -
Flags: review?(mhammond)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•12 years ago
|
||
This has a test fix.
Attachment #638755 -
Attachment is obsolete: true
Attachment #638755 -
Flags: review?(mhammond)
Attachment #638782 -
Flags: review?(mhammond)
|
||
Updated•12 years ago
|
Attachment #638782 -
Flags: review?(mhammond) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Flags: in-testsuite+
Target Milestone: --- → Firefox 16
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•