rename FrameWorker.jsm exported symbol (FrameWorker -> getFrameWorkerHandle?)

RESOLVED FIXED in Firefox 16

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
Firefox 16
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Since this function isn't a constructor, and the returned object isn't a FrameWorker object, I think it makes sense to change the exported symbol's name.

I picked "getFrameWorkerHandle" because I'd chosen "WorkerHandle" in the previous patch. I'm not particularly attached to that name, though, and it is kind of ugly. Feedback desired!
Created attachment 638755 [details] [diff] [review]
patch
Attachment #638755 - Flags: review?(mhammond)
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Created attachment 638782 [details] [diff] [review]
patch

This has a test fix.
Attachment #638755 - Attachment is obsolete: true
Attachment #638755 - Flags: review?(mhammond)
Attachment #638782 - Flags: review?(mhammond)

Updated

5 years ago
Attachment #638782 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a70007cba6bf
Flags: in-testsuite+
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/a70007cba6bf
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.