770628 - mac and windows b2g desktop builds don't run because of missing library

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[[e-mail] (:bhearsum)]

Trying to run one from the command line gives me:
bld-lion-r5-031:MacOS cltbld$ ./b2g 
dyld: Library not loaded: @executable_path/libmozglue.dylib
  Referenced from: /Volumes/B2G/B2G.app/Contents/MacOS/./b2g
  Reason: image not found
Trace/BPT trap: 5

And indeed, that's missing from the package:
bld-lion-r5-031:MacOS cltbld$ ls
XUL				greprefs.js			libplds4.dylib
application.ini			hyphenation			libsmime3.dylib
b2g				libfreebl3.dylib		libsoftokn3.dylib
chrome				libmozalloc.dylib		libssl3.dylib
chrome.manifest			libmozsqlite3.dylib		libxpcom.dylib
components			libnspr4.dylib			modules
crashreporter-override.ini	libnss3.dylib			platform.ini
crashreporter.app		libnssckbi.dylib		plugin-container.app
defaults			libnssdbm3.dylib		removed-files
dependentlibs.list		libnssutil3.dylib		res
dictionaries			libplc4.dylib			run-mozilla.sh

Could be a package manifest issue, maybe?

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Looks like they the library is being built.  Your idea of it being missing from the packaging manifest seems like a reasonable possibility.

make -C build libs
rm -f libmozglue.dylib
/builds/slave/m-cen-osx64-gecko-ntly/build/obj-firefox/_virtualenv/bin/python /builds/slave/m-cen-osx64-gecko-ntly/build/config/pythonpath.py -I../../config /builds/slave/m-cen-osx64-gecko-ntly/build/config/expandlibs_exec.py --depend .deps/libmozglue.dylib.pp --target libmozglue.dylib --uselist --  /usr/local/bin/ccache /usr/bin/g++-4.2  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wempty-body -Wno-ctor-dtor-privacy -Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros -Wcast-align -DMOZ_ENABLE_JS_DUMP -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fshort-wchar -pthread -DNO_X11 -pipe  -DNDEBUG -DTRIMMED -g -O3 -fomit-frame-pointer -fPIC  -o libmozglue.dylib      -framework Cocoa -lobjc  -framework ExceptionHandling -Wl,-executable_path,/builds/slave/m-cen-osx64-gecko-ntly/build/obj-firefox/dist/bin -Wl,-dead_strip  ../../memory/build/libmemory.a ../../mfbt/libmfbt.a -dynamiclib -install_name @executable_path/libmozglue.dylib -compatibility_version 1 -current_version 1 -single_module     
chmod +x libmozglue.dylib
/builds/slave/m-cen-osx64-gecko-ntly/build/obj-firefox/config/nsinstall -L /builds/slave/m-cen-osx64-gecko-ntly/build/obj-firefox/mozglue/build -m 755 libmozglue.dylib ../../dist/lib
/builds/slave/m-cen-osx64-gecko-ntly/build/obj-firefox/config/nsinstall -L /builds/slave/m-cen-osx64-gecko-ntly/build/obj-firefox/mozglue/build -m 755 libmozglue.dylib ../../dist/bin
make -C tests libs

Comment 2

[Hernán Rodriguez Colmeiro (:peregrino)]

Attachment: Proposed patch

This is the patch I had in my queue that fixes this. I've already sent it to try and passes all the tests.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Hernán Rodriguez Colmeiro (:peregrino) from comment #2)
> Created attachment 638838 [details] [diff] [review]
> Proposed patch
> 
> This is the patch I had in my queue that fixes this. I've already sent it to
> try and passes all the tests.

This patch fixes my local build and package of Mac B2G desktop.

$ ls /Volumes/B2G\ 1/B2G.app/Contents/MacOS/libmozglue.dylib 
/Volumes/B2G 1/B2G.app/Contents/MacOS/libmozglue.dylib

$ /Volumes/B2G\ 1/B2G.app/Contents/MacOS/b2g 
Opened socket on 9999
<snip>
$ echo $?
0

Comment 4

[[e-mail] (:bhearsum)]

This is a problem on Windows, too.

Comment 5

[Michael Wu [:mwu]]

This patch is basically a b2g port of bug 716397

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 638838 [details] [diff] [review]
Proposed patch

khuey thinks it's reasonable, and it looks ok to me.

Comment 7

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Michael Wu [:mwu] from comment #6)
> Comment on attachment 638838 [details] [diff] [review]
> Proposed patch
> 
> khuey thinks it's reasonable, and it looks ok to me.

many thanks mwu + khuey for the r+. 

checkin-needed!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7ccd19c8767

Also, please give your patches real commit messages when you attach them here :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d7ccd19c8767

Comment 10

[Hernán Rodriguez Colmeiro (:peregrino)]

(In reply to Ryan VanderMeulen from comment #8)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/d7ccd19c8767
> 
> Also, please give your patches real commit messages when you attach them
> here :)

Heh, will do. Sorry about that one :)

Comment 11

[[e-mail] (:bhearsum)]

I got a bunch of reports on my blog about Windows still not working, citing a missing gkmedias.dll.

Comment 12

[Michael Wu [:mwu]]

Windows is broken for a different reason than osx - a new bug is probably more appropriate.

Comment 13

[[e-mail] (:bhearsum)]

(In reply to Michael Wu [:mwu] from comment #12)
> Windows is broken for a different reason than osx - a new bug is probably
> more appropriate.

Filed bug 771095.