771095 - Windows b2g desktop builds don't run because gkmedias.dll is missing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[[e-mail] (:bhearsum)]

Got lots of reports on my blog post about this. Eg:
It is not working. I download it for windows and when I try to run I get error that say “This application has faild to run beacuse the gkmedias.dll not found.” Then i copy gkmedias.dll from my firefox nightly folder to b2g folder to see if works but id didn’t. I get other error now “The insertion point _invalid_parameter_noinfo_noreturn process could not be located in dynamic link library MSVCR100.dll”

Some people got it working by copying in one from Firefox, which suggests this is the only missing library now that bug 770628 is fixed.

Comment 1

[Mike Hommey [:glandium]]

sounds like gkmedias is missing in b2g/installer/package-manifest.in. That's what we get from not having a manifest for toolkit.

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: include gkmedias.dll in windows packaging

This patch includes gkmedias.dll in the pacakge.  I have verified that my local build that has been packaged with "make package" is able to start and includes gkmedias.dll in the package.  It is not possible to test this out on try currently because of bug 772580.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Removing dependency on bug 772580 because I was able to work around this locally.  I still think having these builds available on try would be helpful, and would have saved me a lot of time today.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to John Ford [:jhford] from comment #3)
> Removing dependency on bug 772580 because I was able to work around this
> locally.  I still think having these builds available on try would be
> helpful, and would have saved me a lot of time today.

That bug won't give you desktop builds on try -- builds that are only done on a nightly basis aren't on try at all (eg, Firefox Qt/RPM, the old fennec desktop builds, etc.). We should probably find a way to make that happen, but just updating the syntax won't do it.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Ben Hearsum [:bhearsum] from comment #4)
> That bug won't give you desktop builds on try -- builds that are only done
> on a nightly basis aren't on try at all (eg, Firefox Qt/RPM, the old fennec
> desktop builds, etc.). We should probably find a way to make that happen,
> but just updating the syntax won't do it.

I think you have bug 772580 confused for bug 767501 :)

Comment 6

[[e-mail] (:bhearsum)]

(In reply to John Ford [:jhford] from comment #5)
> (In reply to Ben Hearsum [:bhearsum] from comment #4)
> > That bug won't give you desktop builds on try -- builds that are only done
> > on a nightly basis aren't on try at all (eg, Firefox Qt/RPM, the old fennec
> > desktop builds, etc.). We should probably find a way to make that happen,
> > but just updating the syntax won't do it.
> 
> I think you have bug 772580 confused for bug 767501 :)

Indeed I do! Sorry about that.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

http://hg.mozilla.org/integration/mozilla-inbound/rev/169276010be9

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Somehow, this patch wasn't merged with an explicit revision, but instead is included as part of a merge to mozilla-central.

http://hg.mozilla.org/mozilla-central/rev/ca0d192683ad

Ed, is this some sort of history squashing for small patches, or is this an issue in the merge process?

Comment 9

[Ed Morley [:emorley]]

This is not yet on mozilla-central, current tip is 8b639f976a00, so current file is:
http://hg.mozilla.org/mozilla-central/file/8b639f976a00/b2g/installer/package-manifest.in#l46 which doesn't contain the change.

Last merge was from the inbound cset e800d39d1600 (which landed on inbound on Wed Jul 11 10:53:02 2012). The changeset in question only landed on inbound on Wed Jul 11 18:39:50 2012. (All times UTC+1)

Someone will either merge tonight (once the usual bustage from people not using Try is cleared up), or I will do so at start of UK working day tomorrow :-)

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/169276010be9