Closed Bug 770772 Opened 7 years ago Closed 7 years ago

Implement WebappRT test framework on Linux

Categories

(Firefox Graveyard :: Webapp Runtime, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 16

People

(Reporter: adw, Assigned: marco)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 2 obsolete files)

Currently the WebappRT test framework works only on OS X.  It should be updated to work on Linux too.  I think the only thing that needs to be done is to modify the stub executable to (1) respect the -profile command-line argument and (2) look for the Firefox binary in the same directory as the stub executable.  See the changes to webapprt.mm in bug 733631 attachment 638040 [details] [diff] [review]; the changes to the Linux executable should be similar.
Marco - Can you look into this?
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
QA Contact: jsmith
Priority: -- → P3
Blocks: 762744
Attached patch Patch (obsolete) — Splinter Review
Attachment #642209 - Flags: review?(adw)
Attached patch Patch v2 (obsolete) — Splinter Review
Attachment #642209 - Attachment is obsolete: true
Attachment #642209 - Flags: review?(adw)
Attachment #642211 - Flags: review?(adw)
Comment on attachment 642211 [details] [diff] [review]
Patch v2

Review of attachment 642211 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Marco.

::: webapprt/gtk2/webapprt.cpp
@@ +255,5 @@
> +  if (access(firefoxDir, F_OK) != -1) {
> +    if (GRELoadAndLaunch(firefoxDir))
> +      return 0;
> +    else
> +      return 255;

Nit: just return 255, no else branch needed.
Attachment #642211 - Flags: review?(adw) → review+
Attached patch Patch v3Splinter Review
Fixed the nit.
Attachment #642211 - Attachment is obsolete: true
Whiteboard: [qa-]
https://hg.mozilla.org/mozilla-central/rev/5b5f4f615e00
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.