Closed
Bug 770772
Opened 12 years ago
Closed 12 years ago
Implement WebappRT test framework on Linux
Categories
(Firefox Graveyard :: Webapp Runtime, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: adw, Assigned: marco)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 2 obsolete files)
6.88 KB,
patch
|
Details | Diff | Splinter Review |
Currently the WebappRT test framework works only on OS X. It should be updated to work on Linux too. I think the only thing that needs to be done is to modify the stub executable to (1) respect the -profile command-line argument and (2) look for the Firefox binary in the same directory as the stub executable. See the changes to webapprt.mm in bug 733631 attachment 638040 [details] [diff] [review]; the changes to the Linux executable should be similar.
Comment 1•12 years ago
|
||
Marco - Can you look into this?
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Updated•12 years ago
|
QA Contact: jsmith
Updated•12 years ago
|
Priority: -- → P3
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #642209 -
Flags: review?(adw)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #642209 -
Attachment is obsolete: true
Attachment #642209 -
Flags: review?(adw)
Attachment #642211 -
Flags: review?(adw)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 642211 [details] [diff] [review] Patch v2 Review of attachment 642211 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, Marco. ::: webapprt/gtk2/webapprt.cpp @@ +255,5 @@ > + if (access(firefoxDir, F_OK) != -1) { > + if (GRELoadAndLaunch(firefoxDir)) > + return 0; > + else > + return 255; Nit: just return 255, no else branch needed.
Attachment #642211 -
Flags: review?(adw) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5f4f615e00
Flags: in-testsuite+
Keywords: checkin-needed
Updated•12 years ago
|
Whiteboard: [qa-]
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5b5f4f615e00
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•