770772 - Implement WebappRT test framework on Linux

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P3)

Description

[Drew Willcoxon :adw]

Currently the WebappRT test framework works only on OS X.  It should be updated to work on Linux too.  I think the only thing that needs to be done is to modify the stub executable to (1) respect the -profile command-line argument and (2) look for the Firefox binary in the same directory as the stub executable.  See the changes to webapprt.mm in bug 733631 attachment 638040 [details] [diff] [review]; the changes to the Linux executable should be similar.

Comment 1

[Jason Smith [:jsmith]]

Marco - Can you look into this?

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch v2

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 642211 [details] [diff] [review]
Patch v2

Review of attachment 642211 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Marco.

::: webapprt/gtk2/webapprt.cpp
@@ +255,5 @@
> +  if (access(firefoxDir, F_OK) != -1) {
> +    if (GRELoadAndLaunch(firefoxDir))
> +      return 0;
> +    else
> +      return 255;

Nit: just return 255, no else branch needed.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Patch v3

Fixed the nit.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5f4f615e00

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b5f4f615e00