Implement WebappRT test framework on Linux

RESOLVED FIXED in Firefox 16

Status

Firefox Graveyard
Webapp Runtime
P3
normal
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: adw, Assigned: marco)

Tracking

Trunk
Firefox 16
x86
Linux
Dependency tree / graph
Bug Flags:
in-testsuite +

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Currently the WebappRT test framework works only on OS X.  It should be updated to work on Linux too.  I think the only thing that needs to be done is to modify the stub executable to (1) respect the -profile command-line argument and (2) look for the Firefox binary in the same directory as the stub executable.  See the changes to webapprt.mm in bug 733631 attachment 638040 [details] [diff] [review]; the changes to the Linux executable should be similar.
Marco - Can you look into this?
(Assignee)

Updated

5 years ago
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED

Updated

5 years ago
QA Contact: jsmith

Updated

5 years ago
Priority: -- → P3
Blocks: 762744
(Assignee)

Comment 2

5 years ago
Created attachment 642209 [details] [diff] [review]
Patch
Attachment #642209 - Flags: review?(adw)
(Assignee)

Comment 3

5 years ago
Created attachment 642211 [details] [diff] [review]
Patch v2
Attachment #642209 - Attachment is obsolete: true
Attachment #642209 - Flags: review?(adw)
Attachment #642211 - Flags: review?(adw)
(Reporter)

Comment 4

5 years ago
Comment on attachment 642211 [details] [diff] [review]
Patch v2

Review of attachment 642211 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Marco.

::: webapprt/gtk2/webapprt.cpp
@@ +255,5 @@
> +  if (access(firefoxDir, F_OK) != -1) {
> +    if (GRELoadAndLaunch(firefoxDir))
> +      return 0;
> +    else
> +      return 255;

Nit: just return 255, no else branch needed.
Attachment #642211 - Flags: review?(adw) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 642285 [details] [diff] [review]
Patch v3

Fixed the nit.
Attachment #642211 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5f4f615e00
Flags: in-testsuite+
Keywords: checkin-needed

Updated

5 years ago
Whiteboard: [qa-]
https://hg.mozilla.org/mozilla-central/rev/5b5f4f615e00
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.