Closed Bug 770785 Opened 8 years ago Closed 7 years ago

Delete client record from server on account removal

Categories

(Firefox for Android :: Android Sync, defect, P2)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: rnewman, Assigned: nalexander)

References

Details

It'd be nice if we could delete all of our client records on uninstall, too.

Note that client records are TTLed, so after three weeks the old records should disappear.

If a user ran a really old version of Android Sync, it'll perhaps have left TTL-less records on the server. In that case, a node reassignment will eventually clean up.
I remember there being a bug whereby it was requested to have the ability to remove devices from sync. I can't for the life find the bug number though.
Priority: P3 → P2
(In reply to Richard Newman [:rnewman] from comment #0)
> It'd be nice if we could delete all of our client records on uninstall, too.

Android: I'm sorry, Dave. I'm afraid I can't do that.

http://developer.android.com/intl/zh-CN/reference/android/content/Intent.html#ACTION_PACKAGE_REMOVED

http://stackoverflow.com/questions/6209730/is-it-possible-to-detect-android-app-uninstall
Test instructions:

This is easiest to test with two distinct Android devices and a fresh Sync account.

1. pair first Android device to fresh Sync account.
2. verify Sync is correct, and look for logs like:

I FxSync(12791)               fennec_ncalexan :: SyncAdapter :: Syncing account named nalexander+test0724@mozilla.com for authority org.mozilla.fennec_ncalexan.db.browser.
I FxSync(12791)               fennec_ncalexan :: SyncAdapter :: Client is named 'Fennec ncalexan on Transformer Prime TF201', has client guid FQ_4HyD-5uQP, and has 0 clients.

Make a note of the client name and guid (in this case, 'Fennec ncalexan on Transformer Prime TF201' and FQ_4HyD-5uQP).

3. from Fennec, browse to a page and select Share > Firefox Sync.
4. verify your client name appears in target list.
5. from Android > Settings > Accounts & sync, select Sync account and delete it.
6. verify logs like:

I FxSync(12791)               fennec_ncalexan :: SyncAuthService :: Account named nalexander+test0724@mozilla.com being removed; deleting saved pickle file 'sync.account.json'.
I FxSync(12791)               fennec_ncalexan :: SyncAuthService :: Account named nalexander+test0724@mozilla.com being removed; deleting client record from server.
...
I FxSync(12791)               fennec_ncalexan :: ClientRecTerminator :: Deleted client record with GUID FQ_4HyD-5uQP from server.

Your client GUID should appear in the log.

To verify client record is really deleted from the server:

7. pair second Android device to Sync account.
8. from Fennec, browse to a page and select Share > Firefox Sync.
9. verify the old client name does NOT appear in target list.
(In reply to Nick Alexander :nalexander from comment #2)

> Android: I'm sorry, Dave. I'm afraid I can't do that.

Oh, I know. Just wishful thinking :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e37291492a0
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/3e37291492a0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 799120
Product: Mozilla Services → Android Background Services
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.