770803 - make installer pretty step no longer running for Thunderbird builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mark Banner (:standard8)]

Bug 760168 made the installer step optional depending on the branch and platform configuration.

It added enabling the installer to Firefox's config.py but didn't do the same for Thunderbird's config.py, this is causing builds to show test failures with:

make: Entering directory `/e/builds/moz2_slave/tb-c-cen-w32/build/objdir-tb/mozilla/tools/update-packaging'
test -f "/e/builds/moz2_slave/tb-c-cen-w32/build/objdir-tb/mozilla/tools/update-packaging/../../dist/win32/en-US/Daily Setup 16.0a1.exe"
make: Leaving directory `/e/builds/moz2_slave/tb-c-cen-w32/build/objdir-tb/mozilla/tools/update-packaging'
make: *** [complete-patch] Error 1

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] Add enable's for thunderbird

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 639009 [details] [diff] [review]
[buildbot-configs] Add enable's for thunderbird

Looks good, thanks.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

I'm going to leave it to bhearsum and the folks on the hook for the betas to figure out how they want to land this and bug 770806.

Comment 4

[[e-mail] (:bhearsum)]

SeaMonkey might need adjustments too, I'm not sure if they inherit this code from us or not.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 639009 [details] [diff] [review]
[buildbot-configs] Add enable's for thunderbird

Landed on default and production.

Comment 6

[[e-mail] (:bhearsum)]

Now in production.