Closed Bug 770803 Opened 10 years ago Closed 10 years ago

make installer pretty step no longer running for Thunderbird builds

Categories

(Release Engineering :: General, defect)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 760168 made the installer step optional depending on the branch and platform configuration.

It added enabling the installer to Firefox's config.py but didn't do the same for Thunderbird's config.py, this is causing builds to show test failures with:

make: Entering directory `/e/builds/moz2_slave/tb-c-cen-w32/build/objdir-tb/mozilla/tools/update-packaging'
test -f "/e/builds/moz2_slave/tb-c-cen-w32/build/objdir-tb/mozilla/tools/update-packaging/../../dist/win32/en-US/Daily Setup 16.0a1.exe"
make: Leaving directory `/e/builds/moz2_slave/tb-c-cen-w32/build/objdir-tb/mozilla/tools/update-packaging'
make: *** [complete-patch] Error 1
Comment on attachment 639009 [details] [diff] [review]
[buildbot-configs] Add enable's for thunderbird

Looks good, thanks.
Attachment #639009 - Flags: review?(mbanner) → review+
I'm going to leave it to bhearsum and the folks on the hook for the betas to figure out how they want to land this and bug 770806.
SeaMonkey might need adjustments too, I'm not sure if they inherit this code from us or not.
Comment on attachment 639009 [details] [diff] [review]
[buildbot-configs] Add enable's for thunderbird

Landed on default and production.
Attachment #639009 - Flags: checked-in+
Now in production.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.