770806 - make installer might not be called for releases any more after bug 760168

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Mark Banner (:standard8)]

In looking around at bug 770803, I now believe that Firefox and Thunderbird release builds aren't going to be running "make installer". Here's the info:

http://hg.mozilla.org/build/buildbotcustom/rev/31143b64c29e#l3.95

changed the "make installer" step to be set if enableInstaller is true.

http://hg.mozilla.org/build/buildbotcustom/rev/31143b64c29e#l3.37

added the enableInstaller parameter to MercurialBuildFactory, but it defaults to false.

http://hg.mozilla.org/build/buildbotcustom/rev/31143b64c29e#l2.1

added enableInstaller to the dep and nightly build factory arguments.

Neither http://hg.mozilla.org/build/buildbotcustom/rev/31143b64c29e nor http://hg.mozilla.org/build/buildbot-configs/rev/24cff1e01594 added anything to the ReleaseBuildFactory arguments which would be able to get enableInstaller set to true - and due to the inheritance, MercurialBuildFactory will end up defaulting to false.

Hence I think for both Firefox and Thunderbird releases enableInstaller is now going be false, and the make installer step on Windows won't be run.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

I did a builder dump of a release master and confirmed that this analysis is 100.000% correct.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbotcustom] pass on enable_installer for release en-US

With this and bug 770803, the dump master output is unchanged (for non-B2G builds) after the bug 760168 landing.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 639010 [details] [diff] [review]
[buildbotcustom] pass on enable_installer for release en-US

Should be all we need for this bug...landed on default on production.

Thanks for the patch, Nick.

Comment 4

[[e-mail] (:bhearsum)]

Now in production.