770808 - [HiDPI] icons appearing on the location bar

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: icons, v1.0

Included icons:
error_page_site_icon.tiff
feed.tiff
globe_ico.tiff
history_icon.tiff
security_broken.tiff
security_lock.tiff

Comment 1

[philippe (part-time)]

Attachment: screenshot 1

feed icon, security lock, with other icons visible on tabs.

Comment 2

[philippe (part-time)]

Attachment: screenshot 2: default favicon (hidpi mode)

Comment 3

[Derek Schrock]

Comment on attachment 638997 [details]
icons, v1.0

Everything looks good.

Comment 4

[philippe (part-time)]

Attachment: icons, v1.01

With some minor updates in the @2x error_page_site_icon.tiff (smoothing out some rough edges) and a blocked favicon for malware pages which I had forgotten to include (popup_blocked_icon.tiff)

The latter also appears on the warning bar for blocked pop ups (displays correctly in HiDPI mode!).

Comment 5

[philippe (part-time)]

Attachment: screenshot 3

showing the updated error page icon (on a tab), the 'blocked' favicon on a second tab and the popup bar.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Can you do tab_loading (from bug 419378) with this set as well?  It's really a piece of tabs, but it's based on globe_ico, which you're doing here.

Comment 7

[philippe (part-time)]

(In reply to Smokey Ardisson (not following bugs - do not email) from comment #6)
> Can you do tab_loading (from bug 419378) with this set as well?  It's really
> a piece of tabs, but it's based on globe_ico, which you're doing here.

Oh, yeah, I forgot that one. Before I proceed, any feedback on the refreshed favicon (globe_ico) ? I think I'll add some details in the landmass (mountains, rivers and a giraffe…), at least for the @2x image.

Comment 8

[philippe (part-time)]

Attachment: alternate globe_ico, incl tab_loading icon

It occurred to me that the globe_ico default favicon could match the globe inside the application icon / camino logo.

This implements this (with a slight tweak to brighten the colors a little accounting for the small size of the icon).

I've included a tab_loading image based on the same.

Comment 9

[philippe (part-time)]

Attachment: screenshot, alternate globe_ico favion

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 640127 [details]
alternate globe_ico, incl tab_loading icon

I like this idea, but it's a big change design-wise (and especially color-wise), so hold on to the sources, but we don't want to do this for Camino 2.x, particularly as a side-effect of making Retina images ;-)

Comment 11

[philippe (part-time)]

Attachment: icons, v1.2

Including tab_loading images, further polish to the globe_ico images, some polish on other images.

Depending on which computer I am looking at tab_loading it might look slightly more saturated then the original image. Not sure.

Comment 12

[philippe (part-time)]

Attachment: screenshot v1.2, hidpi

Comment 13

[philippe (part-time)]

Attachment: screenshot v1.2, low resolution

Comment 14

[philippe (part-time)]

Attachment: icons v1.2

Oops, I omitted one file in the previous package, sorry about that :-(

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Question: why did the existing 16x16px icons change in almost every case? E.g., 
1) error_page_site_icon has a fainter top point in the new file than the old,
2) feed has a color shift/less gradient in new file compared to the old, 
3) globe_ico has lighter ocean in the new file than the old,
4) history_icon has a narrower blue band in the new file than the old, and 
5) tab_loading has a lighter ocean and darker edge in the new file than the old.

Only popup_blocked and the two lock icons don't seem have changes to the 16px versions.

Other than that, I have only limited concerns with the new 2x icons:

a) Try to better match the ocean color to the original 1x color in the 2x globe/loading icons
b) Try to better match the gradient/color to the original 1x gradient/color in the 2x feed icon
c) On error_page_site_icon, can you make the edges more uniform in width/color?  The bottom seems extra thick and extra dark (maybe make the 2nd row more grey?), while the sides and especially the topmost point seem thinner/lighter (I really wish I had a real retina display to look at this one in person to see what it looked like in 2x).

Comment 16

[philippe (part-time)]

(In reply to Smokey Ardisson (not following bugs - do not email) from comment #15)
> Question: why did the existing 16x16px icons change in almost every case?
> E.g., 
> 1) error_page_site_icon has a fainter top point in the new file than the old,
> 2) feed has a color shift/less gradient in new file compared to the old, 
> 3) globe_ico has lighter ocean in the new file than the old,
> 4) history_icon has a narrower blue band in the new file than the old, and 
> 5) tab_loading has a lighter ocean and darker edge in the new file than the
> old.
> 
> Only popup_blocked and the two lock icons don't seem have changes to the
> 16px versions.

Because that I had to build everything from scratch, and found it much easier to recreate all files and then work with those to keep colour consistency, etc.
Gradient in particular are **very** hard to guess based on the very small size available (16x16px & smaller).

> 
> Other than that, I have only limited concerns with the new 2x icons:
> 
> a) Try to better match the ocean color to the original 1x color in the 2x
> globe/loading icons
> b) Try to better match the gradient/color to the original 1x gradient/color
> in the 2x feed icon
> c) On error_page_site_icon, can you make the edges more uniform in
> width/color?  The bottom seems extra thick and extra dark (maybe make the
> 2nd row more grey?), while the sides and especially the topmost point seem
> thinner/lighter (I really wish I had a real retina display to look at this
> one in person to see what it looked like in 2x).

Ok, will try.

Note that I won't have much time to touch those things for the next 3 weeks, possibly till the end of August.

Comment 17

[philippe (part-time)]

Attachment: icons v1.3

Comment 18

[philippe (part-time)]

(In reply to philippe (part-time) from comment #17)
> Created attachment 663922 [details]
> icons v1.3


Updated per review comments.
Most 16x16 icons reuse the old version, except feed.tiff and error_page_site_icon.tiff

Comment 19

[philippe (part-time)]

Attachment: screenshot 1.3

various views at HiDPI

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 663922 [details]
icons v1.3

1) popup_blocked is missing from this iteration ("_bug770808_tiff-v2") of these icons

2) tab_loading looks like it's from your Graphite icon package (the 1x icon is totally different, and grey rather than faded blue; the 2x is the right design, just grey).

The rest of the icons look good (error_page_site_icon looks a little fuzzy in the 2x screenshot at 50%, but it's nice and crisp every other place, so I'm writing that off to its shape/line directions and the way the apps downscale the screenshot, which we've seen before).

r- because of the wonky tab_loading icon, but other than that, I think we're good to go (assuming gremlins haven't made any unexpected changes to the missing popup_blocked)

Comment 21

[philippe (part-time)]

Attachment: icons v1.4

* now with popup_blocked
* updated tab_loading (dunno what happened to that one; chaos in the milk truck? )

Comment 22

[philippe (part-time)]

Attachment: screenshot v1.4

popup_blocked, tab_loading in HiDPI mode

Comment 23

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 669823 [details]
icons v1.4

(In reply to philippe (part-time) from comment #21)
> * updated tab_loading (dunno what happened to that one; chaos in the milk
> truck? )

If it were on my end, I'd have blamed jinn.  But the new tab_loading is great, so r/icon-sr=ardissone (and thanks, once again!)

Comment 24

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/a04db030001b