770882 - resizer.xml visible in the debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Paul Rouget [:paul]]

Attachment: screenshot

STR:
- open about:blank
- open the debugger
- open the Responsive Mode

Comment 1

[Paul Rouget [:paul]]

I can't reproduce. Maybe fixed already.

Comment 2

[Loic]

STR work for me on Win 7 with the latest Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 (Built from http://hg.mozilla.org/mozilla-central/rev/87db9617a885).

After opening the responsive view, the debugger loads resizer.xml:

<?xml version="1.0"?>
<!-- This Source Code Form is subject to the terms of the Mozilla Public
   - License, v. 2.0. If a copy of the MPL was not distributed with this
   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->


<bindings id="resizerBindings"
   xmlns="http://www.mozilla.org/xbl">

  <binding id="resizer">
    <resources>
      <stylesheet src="chrome://global/skin/resizer.css"/>
    </resources>
    <implementation>
      <constructor>
      <![CDATA[
        // don't do this for viewport resizers; causes a crash related to
        // bugs 563665 and 581536 otherwise
        if (this.parentNode == this.ownerDocument.documentElement)
          return;

        // if the direction is rtl, set the rtl attribute so that the
        // stylesheet can use this to make the cursor appear properly
        var direction = window.getComputedStyle(this, "").direction;
        if (direction == "rtl") {
          this.setAttribute("rtl", "true");
        }
      ]]>
      </constructor>
    </implementation>
  </binding>

</bindings>

Comment 3

[Kevin Dangoor]

There's a screenshot in bug 767390 that also shows resizer.xml in the Debugger.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Related bug: https://bugzilla.mozilla.org/show_bug.cgi?id=760882

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch

OK, so the fact that it took me so long to see what is wrong here, is rather embarrassing. Apparently though a holiday can seriously clear your mind!

Comment 6

[Victor Porof [:vporof][:vp]]

Wow...

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 653413 [details] [diff] [review]
Working patch

Seem to be able to trigger this with a reload while the debugger's active. This should fix.

Comment 8

[Rob Campbell [:rc] (:robcee)]

doesn't apply to beta, would like to include it in aurora and beta as it's a pretty basic patch that pre-empts some user confusion.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch for beta

This applies cleanly to beta.

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/df17d6a5a330

Comment 11

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 654138 [details] [diff] [review]
Patch for beta

we missed the boat on beta. Sorry.

Comment 12

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 653413 [details] [diff] [review]
Working patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature. 
User impact if declined: users may see mysterious system scripts in the debugger during reloads.
Testing completed (on m-c, etc.): on m-c, local
Risk to taking this patch (and alternatives if risky): negligible.
String or UUID changes made by this patch:  none

I think this should apply fairly easily on aurora, requesting approval.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 653413 [details] [diff] [review]
Working patch

I don't see the need to track this for 16, we can approve for Aurora though.

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/df17d6a5a330

Comment 15

[Panos Astithas (he/him) [:past] (please ni?)]

Landed in aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/805e936380ab