771055 - Allow TBPL to load in IE10

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Changes to let IE load TBPL

Currently, TBPL can't load in Internet Explorer.

Attached is a patch that changes that. (At least for me, on Windows 8, with IE10.)

The first problem is that document.baseURI isn't supported in IE. If I change it from document.baseURI to document.location.href, IE is able to get past this point. It looks like the replace() call on both baseURI and location.href end up returning the same string, and everything I tried testing locally seemed to work okay. Is there some reason TBPL needs to use baseURI?

After the baseURI change, the ajax() request in js/Data.js that fetches the builds was failing, throwing a NO TRANSPORT error. Apparently in IE you have to explicitly tell Jquery to do cross-origin requests, which is what that "$.support.cors = true;" line near the top of the file does.


With these two changes, I was able to load every tree that I tried in TBPL in both IE10 and Firefox 16.

Comment 1

[Markus Stange [:mstange]]

(In reply to Wes Kocher (:KWierso) from comment #0)
> Is there some reason TBPL needs to use baseURI?

I don't think so, no.

Comment 2

[Ed Morley [:emorley]]

Is this ok to land?

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Ed Morley [:edmorley] from comment #2)
> Is this ok to land?

I guess?

Comment 4

[Ed Morley [:emorley]]

Testing locally (using the baseURL trick to run from local filesystem):

Latest Nightly works fine; however IE9 hangs loading the page.

Don't know if this is an IE9 thing (and IE10 would work fine if I were using it), or whether it is due to running from the local filesystem.

Comment 5

[Jeff Walden [:Waldo]]

Isn't IE10 the first version of IE to support CORS?  I thought previous versions required the IE-specific XDomainRequest, and we basically WONTFIX'd bug 647497 sub silentio due to that requirement.

Comment 6

[Ed Morley [:emorley]]

Quite possibly, however on Win7 I have no way to test IE10 yet (yey Microsoft).

Comment 7

[Ed Morley [:emorley]]

I still don't have a way to test on Win7, so I've just gone ahead and landed it:
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/2f8984e581fd

We will likely have a push to prod early next week.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Just tested tbpl-dev using IE10 and it appears to work correctly.

Comment 9

[Ed Morley [:emorley]]

Great! Thank you for confirming.

(I'll leave the bug open until the push to production).

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Hrm, though I do see bug 764803 in IE10 when trying to add a comment.

And I get a "Rebuild request for [InsertTestNameHere] Test debug failed. (network error)" error when trying to retrigger a test. It never prompts me for my LDAP account in IE, while it does for Firefox...

Comment 11

[Ed Morley [:emorley]]

(In reply to Wes Kocher (:KWierso) from comment #10)
> And I get a "Rebuild request for [InsertTestNameHere] Test debug failed.
> (network error)" error when trying to retrigger a test. It never prompts me
> for my LDAP account in IE, while it does for Firefox...

Might be worth mentioning that in bug 799540, since they are debating about the spec.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Ed Morley [:edmorley UTC+1] from comment #11)
> Might be worth mentioning that in bug 799540, since they are debating about
> the spec.

Yep, that's the same issue. Signing in to self-serve first lets the retrigger request work. Commented over there.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Just checked production TBPL in IE10, and it works.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And it works on Windows RT in its IE10, on both the Desktop and Metro variants!