Closed Bug 771235 Opened 12 years ago Closed 12 years ago

Port |Bug 754062 - Add services/notifications to services-central| (and related bugs) to SeaMonkey

Categories

(SeaMonkey :: Build Config, defect, P3)

defect

Tracking

(seamonkey2.12 verified)

RESOLVED FIXED
seamonkey2.13
Tracking Status
seamonkey2.12 --- verified

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(3 files)

      No description provided.
Flags: in-testsuite-
Depends on: 754538
Summary: Port |Bug 754062 - Add services/notifications to services-central| to SeaMonkey → Port |Bug 754062 - Add services/notifications to services-central| (and related bugs) to SeaMonkey
Depends on: 757261
Attachment #639626 - Attachment filename: 771235-Av1_AitcComponents.diff → 771235-Av1_bug754538.diff
NB: I'm not adding ("missing") MOZ_SERVICES_SYNC support in SeaMonkey code (ftb) :-|
Attachment #639634 - Flags: review?(bugspam.Callek)
Attachment #639626 - Flags: review?(bugspam.Callek)
Attachment #639626 - Flags: review+
Attachment #639626 - Flags: approval-comm-aurora?
Attachment #639626 - Flags: approval-comm-aurora+
Attachment #639628 - Flags: review?(bugspam.Callek)
Attachment #639628 - Flags: review+
Attachment #639628 - Flags: approval-comm-aurora?
Attachment #639628 - Flags: approval-comm-aurora+
Comment on attachment 639634 [details] [diff] [review]
(Cv1) Port bug 754062 and bug 765294 to SeaMonkey, Support MOZ_SERVICES_SYNC wrt SeaMonkey packaging (only)
[Checked in: Comment 7]

Review of attachment 639634 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but in reality I'd love to have info (in summary form) on what *functionality& the two new defines in confvars.sh is technically adding for us. (I know your adding those things in other bugs)
Attachment #639634 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 639626 [details] [diff] [review]
(Av1) Port |Bug 754538 - Implement AITC Client| to SeaMonkey
[Checked in: Comment 5 & 8]

http://hg.mozilla.org/comm-central/rev/19a27ac8aa3e
Attachment #639626 - Attachment description: (Av1) Port |Bug 754538 - Implement AITC Client| to SeaMonkey → (Av1) Port |Bug 754538 - Implement AITC Client| to SeaMonkey [Checked in: Comment 5]
Comment on attachment 639628 [details] [diff] [review]
(Bv1) Port |Bug 757261 - Implement AITC manager and service| to SeaMonkey
[Checked in: Comment 6 & 8]

http://hg.mozilla.org/comm-central/rev/e81f1cbcca64
Attachment #639628 - Attachment description: (Bv1) Port |Bug 757261 - Implement AITC manager and service| to SeaMonkey → (Bv1) Port |Bug 757261 - Implement AITC manager and service| to SeaMonkey [Checked in: Comment 6]
Comment on attachment 639634 [details] [diff] [review]
(Cv1) Port bug 754062 and bug 765294 to SeaMonkey, Support MOZ_SERVICES_SYNC wrt SeaMonkey packaging (only)
[Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/3118dae53f3d


(In reply to Justin Wood (:Callek) from comment #4)
> I'd love to have info (in summary form) on what
> *functionality& the two new defines in confvars.sh is technically adding for
> us. (I know your adding those things in other bugs)

I'm not sure what you would like exactly.
As a bug, these patches add interfaces wrt "Core/FF" bug 744257.
I don't know/think whether these give SeaMonkey any (user) functionality by default.
Attachment #639634 - Attachment description: (Cv1) Port bug 754062 and bug 765294 to SeaMonkey, Support MOZ_SERVICES_SYNC wrt SeaMonkey packaging (only) → (Cv1) Port bug 754062 and bug 765294 to SeaMonkey, Support MOZ_SERVICES_SYNC wrt SeaMonkey packaging (only) [Checked in: Comment 7]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: 19a27ac8aa3e e81f1cbcca64 to c-a]
Attachment #639626 - Attachment description: (Av1) Port |Bug 754538 - Implement AITC Client| to SeaMonkey [Checked in: Comment 5] → (Av1) Port |Bug 754538 - Implement AITC Client| to SeaMonkey [Checked in: Comment 5 & 8]
Attachment #639628 - Attachment description: (Bv1) Port |Bug 757261 - Implement AITC manager and service| to SeaMonkey [Checked in: Comment 6] → (Bv1) Port |Bug 757261 - Implement AITC manager and service| to SeaMonkey [Checked in: Comment 6 & 8]
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1342224185.1342227160.2282.gz
WINNT 5.2 comm-aurora debug test mochitest-other on 2012/07/13 17:03:05
{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/services/aitc/tests/browser_id_simple.js | Exception thrown at chrome://mochitests/content/browser/services/aitc/tests/browser_id_simple.js:11 - TypeError: BrowserID is undefined
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey-Aurora/1342241579.1342244607.19832.gz
WINNT 5.2 comm-aurora debug test mochitest-other on 2012/07/13 21:52:59

seamonkey2.12: verified.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: