Closed Bug 771236 Opened 12 years ago Closed 10 years ago

Kuma: Editor - Saving and loading sometimes brings back an old version instead of the one you saved

Categories

(developer.mozilla.org Graveyard :: Editing, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: sheppy, Unassigned)

References

Details

(Whiteboard: s=2012-08-22 p=2)

This is creepy. Sometimes you save and exit and then a few minutes later you go back into the editor and get back the previous version instead.
This look like the case of the dataloss I'm experiencing once in a while too.
Related to bug 765649?
I have to believe this is either a caching issue or the new queueing system.
(In reply to John Karahalis [:openjck] from comment #2)
> Related to bug 765649?

I don't think so. Like I said, my guess is that this is probably related to the way we save edit drafts in localstorage. 

It doesn't seem to affect the actual generation of rendered pages, and the rendering of pages (ie. the new queueing system) doesn't interact with the editor as far as I know.
Priority: -- → P1
I have not seen this for some time now.
I tried this again on https://developer.allizom.org/en-US/docs/XUL/Attribute/closemenu and I saw it a couple times - it affected both the editor and the page view.

So I think it's something to do with cache. Saving the page doesn't seem to clear all the various caches.
Component: Website → Docs Platform
QA Contact: website
Whiteboard: s=2012-08-22
Whiteboard: s=2012-08-22 → s=2012-08-22 p=2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Opened bug 784752 for re-enabling memcached. Wondering if it's even worthwhile considering that not having it only seems to affect page load time by a few milliseconds.
(In reply to John Karahalis [:openjck] from comment #9)
> Opened bug 784752 for re-enabling memcached. Wondering if it's even
> worthwhile considering that not having it only seems to affect page load
> time by a few milliseconds.

IMHO it is, but not anytime soon necessarily.
Version: Kuma → unspecified
Component: Docs Platform → Editing
This happens again. Edit a page, save it. Edit it again, mid-air collision with an old version.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Jean-Yves Perrier [:teoli] from comment #11)
> This happens again. Edit a page, save it. Edit it again, mid-air collision
> with an old version.

Need more details: What page & when?
I get mid-air collision quite often on this page: https://developer.mozilla.org/en-US/docs/Template:CSSRef$edit

Last times 3 times between 00:28 -00:48 PT today.

Note that when I click edit on a page I do a shift-reload right after itnow to prevent this from happening.
Hmm, I haven't been able to reproduce this, and shift-reload shouldn't really have any effect on template source pages or editing in general.
I have a mid-air collision here now https://developer.mozilla.org/en-US/docs/Web/JavaScript/Doc_status Try to save the page. The rendering takes a a bit (the box "new rendering is scheduled" shows up). 

Might it be, if you edit a page which is still in the process of being rendered that something collides? Not sure I can reproduce it this way. Just a thought.
(In reply to Florian Scholz [:fscholz] (elchi3) from comment #15)
> I have a mid-air collision here now
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Doc_status Try to
> save the page. The rendering takes a a bit (the box "new rendering is
> scheduled" shows up). 
> 
> Might it be, if you edit a page which is still in the process of being
> rendered that something collides? Not sure I can reproduce it this way. Just
> a thought.

That's been my impression all along. If there's a page that takes long enough to render that your next save collides, you get this. I'm not sure what the right solution is, but the current situation isn't it. :)
https://developer.mozilla.org/en-US/docs/Project:MDN/ServerCharts shows there was a performance dip for a while there. Could have caused the issues temporarily? Or is the issue persistent?
Flags: needinfo?(jypenator)
Flags: needinfo?(fscholz)
I just edited (Dec 2, 2013 10:25:32 AM) the page mentioned in comment 15 and I don't see any dip on the charts. However, I got a collision note again.
Flags: needinfo?(fscholz)
I didn't got a single collision for months. I guess this is fixed. Florian, what do you think, can we close this bug?
Flags: needinfo?(jypenator) → needinfo?(fscholz)
Did not happen for me this year afaik. If it happens again, it is probably worth a new bug.
Status: REOPENED → RESOLVED
Closed: 12 years ago10 years ago
Flags: needinfo?(fscholz)
Resolution: --- → WORKSFORME
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.