771277 - Fix XPCShell password authentication tests so that they don't pass around fake docShells

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 669603 introduced a change that makes it impossible for us to mock docShells with JavaScript for our XPCShell tests.

We need to alter our authentication and testing infrastructure so that passing around fake docShells is no longer required.

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix

This patch creates a function on nsIMsgWindow that will return the auth prompt.  This gives us the opportunity in xpcshell tests to not need to fake the docShell.

It also gives us a bit of a clearer function to call when we do really want the auth prompt.

Comment 5

[Mark Banner (:standard8)]

Attachment: The fix v2

Now without commented out sections.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 639436 [details] [diff] [review]
The fix v2

Passes unit tests locally and still seems to work for the prompting users normally.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 639436 [details] [diff] [review]
The fix v2

This doesn't look like the right patch to me...

Comment 8

[Mark Banner (:standard8)]

Attachment: The fix v2

Comment 9

[David :Bienvenu]

looks reasonable, but it'll take me a while to rebuild and test...

Comment 10

[David :Bienvenu]

Comment on attachment 639447 [details] [diff] [review]
The fix v2

sr=me, based on running the mailnews/local tests, and verifying that imap password prompting still works.

Comment 11

[Mark Banner (:standard8)]

I checked this in early pending Mike's review so that we could get the tree green again:

https://hg.mozilla.org/comm-central/rev/e61aeddc94ef

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 639447 [details] [diff] [review]
The fix v2

Review of attachment 639447 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, everything seems to function normally, and I can't really argue with the results on tbpl.

Just two little nits, perhaps worthy of a followup patch.

Great job!

-Mike

::: mailnews/base/public/nsIMsgWindow.idl
@@ +45,5 @@
>     */
>    readonly attribute nsIDocShell messageWindowDocShell;
> +
> +    /**
> +     * Returns the auth prompt associtated with the window. This will only return

Nits:

This block is incorrectly indented, and there's a typo: "associtated" -> "associated".

Comment 13

[Mark Banner (:standard8)]

I eventually got around to pushing the comment-only nits:

https://hg.mozilla.org/comm-central/rev/c1a5b1b4af57