771307 - Disable OMTC for small widgets

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

Currently, when OMTC is enabled, small widgets like tooltips and autocompletion lists are using OMTC with their own pair of Shadowable/ShadowLayerManager. This is overkill.

We need to disable OMTC for such widgets, just like we forced layers acceleration to be disabled for them (bug 751370).

Comment 1

[Nicolas Silva [:nical]]

Attachment: Disables OMTC for popup widgets that are not xul panels.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This patch is bitrotted. Please rebase and re-attach.

Comment 3

[Nicolas Silva [:nical]]

Attachment: Disables OMTC for popup widgets that are not xul panels.

Rebased the patch.

Comment 4

[Nicolas Silva [:nical]]

Attachment: Disables OMTC for popup widgets that are not xul panels.

Ooops... incorrectly rebased previous one, this one is good and checked :)

Comment 5

[Ali Juma [:ajuma]]

Comment on attachment 639567 [details] [diff] [review]
Disables OMTC for popup widgets that are not xul panels.

Review of attachment 639567 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/xpwidgets/nsBaseWidget.cpp
@@ +921,5 @@
>  bool nsBaseWidget::UseOffMainThreadCompositing()
>  {
> +  bool isSmallPopup = ((mWindowType == eWindowType_popup) && 
> +                      (mPopupType != ePopupTypePanel));
> +  return (sUseOffMainThreadCompositing != nsnull) && !isSmallPopup;

return sUseOffMainThreadCompositing && !isSmallPopup;

I'll fix this and land the patch.

Comment 6

[Ali Juma [:ajuma]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cc5e9540b60

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4cc5e9540b60