Closed Bug 771307 Opened 9 years ago Closed 9 years ago

Disable OMTC for small widgets

Categories

(Core :: Graphics: Layers, defect)

x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(1 file, 2 obsolete files)

Currently, when OMTC is enabled, small widgets like tooltips and autocompletion lists are using OMTC with their own pair of Shadowable/ShadowLayerManager. This is overkill.

We need to disable OMTC for such widgets, just like we forced layers acceleration to be disabled for them (bug 751370).
Assignee: nobody → nsilva
Attachment #639455 - Flags: review?(ajuma)
Attachment #639455 - Flags: review?(ajuma) → review+
Keywords: checkin-needed
This patch is bitrotted. Please rebase and re-attach.
Keywords: checkin-needed
Rebased the patch.
Attachment #639455 - Attachment is obsolete: true
Attachment #639558 - Flags: review?(ajuma)
Ooops... incorrectly rebased previous one, this one is good and checked :)
Attachment #639558 - Attachment is obsolete: true
Attachment #639558 - Flags: review?(ajuma)
Attachment #639567 - Flags: review?(ajuma)
Comment on attachment 639567 [details] [diff] [review]
Disables OMTC for popup widgets that are not xul panels.

Review of attachment 639567 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/xpwidgets/nsBaseWidget.cpp
@@ +921,5 @@
>  bool nsBaseWidget::UseOffMainThreadCompositing()
>  {
> +  bool isSmallPopup = ((mWindowType == eWindowType_popup) && 
> +                      (mPopupType != ePopupTypePanel));
> +  return (sUseOffMainThreadCompositing != nsnull) && !isSmallPopup;

return sUseOffMainThreadCompositing && !isSmallPopup;

I'll fix this and land the patch.
Attachment #639567 - Flags: review?(ajuma) → review+
https://hg.mozilla.org/mozilla-central/rev/4cc5e9540b60
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.