The default bug view has changed. See this FAQ.

Disable OMTC for small widgets

RESOLVED FIXED in mozilla16

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla16
x86_64
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Currently, when OMTC is enabled, small widgets like tooltips and autocompletion lists are using OMTC with their own pair of Shadowable/ShadowLayerManager. This is overkill.

We need to disable OMTC for such widgets, just like we forced layers acceleration to be disabled for them (bug 751370).
(Assignee)

Updated

5 years ago
Assignee: nobody → nsilva
(Assignee)

Comment 1

5 years ago
Created attachment 639455 [details] [diff] [review]
Disables OMTC for popup widgets that are not xul panels.
Attachment #639455 - Flags: review?(ajuma)

Updated

5 years ago
Attachment #639455 - Flags: review?(ajuma) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
This patch is bitrotted. Please rebase and re-attach.
Keywords: checkin-needed
(Assignee)

Comment 3

5 years ago
Created attachment 639558 [details] [diff] [review]
Disables OMTC for popup widgets that are not xul panels.

Rebased the patch.
Attachment #639455 - Attachment is obsolete: true
Attachment #639558 - Flags: review?(ajuma)
(Assignee)

Comment 4

5 years ago
Created attachment 639567 [details] [diff] [review]
Disables OMTC for popup widgets that are not xul panels.

Ooops... incorrectly rebased previous one, this one is good and checked :)
Attachment #639558 - Attachment is obsolete: true
Attachment #639558 - Flags: review?(ajuma)
Attachment #639567 - Flags: review?(ajuma)

Comment 5

5 years ago
Comment on attachment 639567 [details] [diff] [review]
Disables OMTC for popup widgets that are not xul panels.

Review of attachment 639567 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/xpwidgets/nsBaseWidget.cpp
@@ +921,5 @@
>  bool nsBaseWidget::UseOffMainThreadCompositing()
>  {
> +  bool isSmallPopup = ((mWindowType == eWindowType_popup) && 
> +                      (mPopupType != ePopupTypePanel));
> +  return (sUseOffMainThreadCompositing != nsnull) && !isSmallPopup;

return sUseOffMainThreadCompositing && !isSmallPopup;

I'll fix this and land the patch.
Attachment #639567 - Flags: review?(ajuma) → review+

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cc5e9540b60
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/4cc5e9540b60
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.