Closed Bug 771394 Opened 8 years ago Closed 8 years ago

Update libpng to version 1.5.11

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

libpng 1.5.11 doesn't really add much over libpng 1.5.10. However, in order to get 1.5.10 to build, we had to take a fix that didn't actually make it in until 1.5.11. To make life simpler, I would like to update us the rest of the 1.5.11 so that we're in sync with upstream again.

Already tested OK on Try. (Yes, I'll fix the commit message before landing)
Attachment #639533 - Flags: review?(justin.lebar+bug)
The part of the patch near the end of png.h looks a little strange:

+#ifdef PNG_APNG_SUPPORTED
-+PNG_EXPORT(234, png_uint_32, png_get_acTL, (png_structp png_ptr,
++PNG_EXPORT(235, png_uint_32, png_get_acTL, (png_structp png_ptr,
 +   png_infop info_ptr, png_uint_32 *num_frames, png_uint_32 *num_plays));
 etc.

as though we're splicing in a patch of a previous patch.  Shouldn't the
"-+" and "++" simply be "-" and "+"?

The "diff" view indicates that a lot of line are removed that
shouldn't be.
Are you sure you aren't looking at the apng.patch part of the diff?
Ryan, maybe we could include one little fix from bug #759067 too?
That should stay in its own bug. However, apng.patch should probably be updated when it lands. Were you going to request review at some point?
Comment on attachment 639533 [details] [diff] [review]
Upgrade libpng to version 1.5.11

r=me, I guess.  Don't forget to update MOZCHANGES as well as the commit message.
Attachment #639533 - Flags: review?(justin.lebar+bug) → review+
(In reply to Ryan VanderMeulen from comment #2)
> Are you sure you aren't looking at the apng.patch part of the diff?

Oops, I was.
Assignee: nobody → ryanvm
https://hg.mozilla.org/mozilla-central/rev/fb3ed8cb1024
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Blocks: 772732
Blocks: 795662
You need to log in before you can comment on or make changes to this bug.