Update libpng to version 1.5.13

RESOLVED FIXED in mozilla18

Status

()

Core
ImageLib
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
mozilla18
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Pretty minor release (we didn't update to 1.5.12 since it was only a build system update that didn't affect us):

Changes since the last public release (1.5.12):
  Do not compile PNG_DEPRECATED, PNG_ALLOC and PNG_PRIVATE when __GNUC__ < 3.
  Removed references to png_zalloc() and png_zfree() from the manual.
  Revised PNG_FP_EXPORT and PNG_FIXED_EXPORT macros to avoid generating
    lone semicolons (patch ported from libpng-1.6.0beta11).
  Corrected handling of the image array and the row_pointers array in example.c
  When png_set_filler is used to strip a filler channel during write, the
    code prior to 1.5 would ignore the case where the output required an
    alpha channel or when the output was a palettized PNG.  In libpng-1.5 the
    ignorance was lost and libpng proceeded to strip the channel resulting
    in a bad (potential memory overwrite) failure later.  This reverts
    the behavior to the pre-1.5 state but issues a warning. libpng-1.6 is
    expected to issue an error on the erroneous png_set_filler call.
  Use png_memset() consistently (pngmem.c contained some bare "memset" calls).

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=a53e0e9b40d2
(Assignee)

Comment 1

5 years ago
Created attachment 666274 [details] [diff] [review]
Upgrade libpng to version 1.5.13
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #666274 - Flags: review?(joe)
(Assignee)

Comment 2

5 years ago
(Don't forget that some of this patch is updates to apng.patch, which can look confusingly like changes being made to other files)
Comment on attachment 666274 [details] [diff] [review]
Upgrade libpng to version 1.5.13

Review of attachment 666274 [details] [diff] [review]:
-----------------------------------------------------------------

s'long as it passes try, rubberstamp=joe
Attachment #666274 - Flags: review?(joe) → review+
(Assignee)

Comment 4

5 years ago
Thanks. I updated the minimum version in configure.in before pushing as well.
https://hg.mozilla.org/integration/mozilla-inbound/rev/346d0973ad0f
Flags: in-testsuite-
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/346d0973ad0f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18

Updated

5 years ago
Blocks: 802348
You need to log in before you can comment on or make changes to this bug.