Closed
Bug 771610
Opened 13 years ago
Closed 13 years ago
Reader Mode: Added items to reader list items do not enter about:reader
Categories
(Firefox for Android Graveyard :: Reader View, defect)
Tracking
(firefox16 verified)
VERIFIED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox16 | --- | verified |
People
(Reporter: aaronmt, Assigned: bnicholson)
References
Details
Attachments
(1 file)
1.24 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
Currently, added items to the Reader List are simply treated as alternative bookmarks. When one adds a page to the reader list and then proceeds to visit the page from the Reader List folder (in the Awesome Screen), the page does not enter about:reader.
ER: Reader List opens added item about with an about:reader URI
AR: Reader List item is opened (basically a bookmark)
I used any article from http://neowin.net to test. I opened the article, opened my menu and selected 'Reader List'. I then went to the folder in the Awesome Screen and selected the item.
Assignee | ||
Comment 1•13 years ago
|
||
Reading list items currently work in the all pages tab; we also need to check for them in the bookmarks tab.
Assignee: nobody → bnicholson
Attachment #640863 -
Flags: review?(margaret.leibovic)
Comment 2•13 years ago
|
||
Comment on attachment 640863 [details] [diff] [review]
Open Reader Mode for Reading List bookmarks
I feel like it would be nicer to do the exact same check we're doing in AllPagesTab [1], but it looks like our bookmarks query doesn't give us back Combined.DISPLAY, so we couldn't do that without changing the query, and I don't think it's worth doing that.
Maybe you should just add a comment about what isInReadingList() actually means. I was initially confused that it didn't take a parameter, but it rather refers to the state of the bookmarks UI.
[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/awesomebar/AllPagesTab.java#202
Attachment #640863 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•13 years ago
|
||
Nightly (07/12), Samsung Galaxy Nexus (Android 4.1.1)
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
Flags: in-moztrap?(fennec)
Updated•13 years ago
|
Target Milestone: --- → Firefox 16
Comment 6•13 years ago
|
||
A new test case was created under the Reading Mode&Reading List test suite in the BFTs run:
https://moztrap.mozilla.org/manage/cases/_detail/6364/
Flags: in-moztrap?(fennec) → in-moztrap+
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•