771817 - Add-on compatibility dialog appears when launching app using different version from that previously run

Status: VERIFIED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

STR:
1) Install "BarFight" from https://apps.mozillalabs.com/appdir/ in an Aurora build
2) Run it (e.g. double click icon in Applications) and close it
3) Un-install the app (delete bundle from Applications)
4) Install the app again, this time in a Nightly build
5) Run the newly installed version

Expected: app launches normally
Actual: "Checking add-on compatibility" dialog appears, stays indefinitely

Comment 1

[:Gavin Sharp [email: [e-mail]]]

We should also do some testing to ensure that this doesn't happen in normal upgrade scenarios (e.g. when users update to Firefox 17 and run the apps they installed with Firefox 16 for the first time).

Comment 2

[Jason Smith [:jsmith]]

I can't reproduce this bug on Win 7. Can you be more specific? Was Aurora running when executing steps 2 and 3? Is step 3 you are meaning the app (BarFight), not Firefox Aurora, right? 

Upon executing step 4, the add-on compatibility dialog came up for when you started Nightly, right? Then, it showed up again in step 5?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I'm testing on Mac. Aurora and Nightly were both running the entire time. "the app" refers to BarFight, in all cases. Step 5 means running the newly installed version of Barfight (installed from Nightly).

The web app runtime needs to disable the add-on compatibility dialog entirely (or perhaps the add-ons manager entirely).

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Oh, duh - I forgot about that. We have a pref to disable that, patch coming up.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/021cff093a3c

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Bah, forgot to hit submit when I landed this on inbound. That changeset was:
https://hg.mozilla.org/integration/mozilla-inbound/rev/021cff093a3c